Conversation
The HTTP/2 verification counted rejected concurrent requests without saying why, so a failure like "25 concurrent requests all resolved (19/25)" gave no clue whether it was rate limiting, a stream error or something else. Each distinct rejection reason (error type, HTTP status, error code, message) is now printed once with a count. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The HTTP/2 verification script (
tests/smoketests/scripts/verify-http2.mjs) fires 25 concurrentdevboxes.listrequests and requires them all to succeed. When some fail, it only prints a count, for exampleFAIL: h2: 25 concurrent requests all resolved (19/25), with no reason.It now prints each distinct rejection reason once with a count: error type, HTTP status, error code and message. For example:
No headers or credentials are printed. Prettier also rewrapped the existing
Promise.allSettledline.Motivation
This check failed during a runloop release-candidate test on dev (runloopai/runloop run 36481903233) with 6 of 25 requests rejected, and nothing in the log said why: rate limiting, HTTP/2 stream limits or a transient API error. Next time the log will say.
Testing
node --checkpasses, and the file is Prettier-clean.🤖 Generated with Claude Code