fix: concurrency correctness#515
Open
hydrogen7797 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses correctness issues in HTTP request handling under concurrency (serverless result posting) and improves endpoint client behavior around retries and final-state handling.
Changes:
- Avoids mutating shared
aiohttpsession headers by passingX-Request-IDper request when posting serverless results (with matching test updates). - Improves endpoint
requests.Sessionretry configuration by mounting retry adapters for bothhttps://andhttp://and expanding retryable status codes. - Fixes endpoint final-state logic by adding
CANCELLEDtoFINAL_STATESand makingis_completed()reference that constant.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_serverless/test_modules/test_http.py | Updates assertions to require X-Request-ID header in result/stream POSTs. |
| runpod/serverless/modules/rp_http.py | Passes request ID per request to avoid shared-session header races. |
| runpod/endpoint/runner.py | Updates retry/backoff policy and mounts adapter for HTTPS as well as HTTP. |
| runpod/endpoint/helpers.py | Aligns final-state constants with is_completed() logic (includes CANCELLED). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+52
| retries = Retry( | ||
| total=5, | ||
| backoff_factor=1, | ||
| status_forcelist=[408, 429, 500, 502, 503, 504], | ||
| allowed_methods=frozenset(["GET", "POST"]), | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.