Bump MSRV to 1.85.0 to fix CI - #130
Merged
Merged
Conversation
One indirect dependency, unescaper, set edition="2024" in a minor release (0.1.9) without declaring a MSRV. Therefore, even with `resolver.incompatible-rust-versions = "fallback"`, cargo will update the dependency and the CI build will fail because our MSRV doesn't support edition 2024. Instead of locking unescaper at version 0.1.8, I prefer to bump our MSRV from 1.84.0 to 1.85.0: The next release will be a MSRV bump from 1.65.0 anyway, and it doesn't matter much if we jump to 1.84.0 or 1.85.0.
eldruin
reviewed
Aug 21, 2026
eldruin
left a comment
eldruin
left a comment
Member
There was a problem hiding this comment.
Sounds good to me, thank you!
eldruin
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One indirect dependency, unescaper, set edition="2024" in a minor release (0.1.9) without declaring a MSRV. Therefore, even with
resolver.incompatible-rust-versions = "fallback", cargo will update the dependency and the CI build will fail because our MSRV doesn't support edition 2024.Instead of locking unescaper at version 0.1.8, I prefer to bump our MSRV from 1.84.0 to 1.85.0: The next release will be a MSRV bump from 1.65.0 anyway, and it doesn't matter much if we jump to 1.84.0 or 1.85.0.
Also contains a trivial fix for a new clippy warning.