Squash & Approve - #828
Open
medzernik wants to merge 2 commits into
Open
Conversation
Added a new command that can squash and, if successful, approve a the latest resulting commit Signed-off-by: David Manca <1900179+medzernik@users.noreply.github.com>
Signed-off-by: David Manca <1900179+medzernik@users.noreply.github.com>
medzernik
force-pushed
the
691/impl-bors-squash-r-plus
branch
from
August 23, 2026 09:43
7fbdf0b to
ab07984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Squash and Approve function. This should fix #691.
Please let me know anything I can do to improve the code if needed.
I would add that in
https://github.com/medzernik/bors/blob/ab07984372498f757ab06438e926a6a6c0424c2b/src/bors/handlers/squash.rs#L25-L27
I wanted to use some more differentiated error states, but with anyhow and the general practice of returning
Ok(X)even if an error technically occurs, I just wrapped theshain anOption<sha>Mentored by: @Kobzol