replace per-crate sqlx folders with just the workspace level - #3442
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
no-sqlx-offline
branch
from
August 11, 2026 20:20
9261f9d to
52ade2f
Compare
syphar
changed the title
syphar
marked this pull request as ready for review
August 11, 2026 20:48
Member
Author
GuillaumeGomez
approved these changes
Aug 11, 2026
Member
|
Middle commit changes look good to me. :) |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I remember trying this in the very beginning of sqlx, and it didn't work. let's try again with a newer sqlx version.
This reduces the amount of sqlx files in PRs by quite a bit (942 files => 164), so should help with reviews a little. I have another idea on top, but that will only work with the docker-based deploys / new infra.
Review: only the middle commit (the justfile update) is necessary, the rest was autogenerated, and eventual issues are covered in CI..
See also transact-rs/sqlx#3362 , transact-rs/sqlx#4376