dirfd file operations (2/4) by Qelxiros · Pull Request #150679 · rust-lang/rust

Qelxiros · 2026-01-04T18:13:00Z

Previous PR: #146341
Reference: #139514
Tracking issue: #120426

rustbot · 2026-01-04T18:13:05Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Qelxiros · 2026-01-04T21:31:36Z

This is going to need a try run for windows at least. @tgross35 I'll let you decide which jobs make the most sense here.

tgross35 · 2026-01-04T23:25:01Z

@bors2 try jobs=x86_64-msvc-*

Cc @the8472 for dirfd, and @ChrisDenton for Windows

dirfd file operations (2/4) try-job: x86_64-msvc-*

rust-bors · 2026-01-05T02:06:13Z

☀️ Try build successful (CI)
Build commit: 796e04e (796e04e9c306cfa50aa215b1e93ebdb1cbdc51d8, parent: e29fcf45e4ae686d77b490bf07320f0d3a2cf35f)

tgross35 · 2026-01-24T05:12:47Z

I haven't had a chance to look here yet, sorry

@rustbot reroll

Qelxiros · 2026-04-01T23:05:13Z

@rustbot reroll

Mark-Simulacrum

The Windows code looks like it could use a second set of eyes from someone with Windows knowledge, unless we manage to remove most of the new code through reusing the existing rename logic.

View changes since this review

Mark-Simulacrum · 2026-04-04T13:21:23Z

+        opts.access_mode(c::DELETE);
+        opts.custom_flags(c::FILE_FLAG_OPEN_REPARSE_POINT | c::FILE_FLAG_BACKUP_SEMANTICS);
+        let handle = self.open_file_native(from, &opts, dir)?;
+        // Calculate the layout of the `FILE_RENAME_INFORMATION` we pass to `NtSetInformationFile`


A bunch of the content here looks similar to

rust/library/std/src/sys/fs/windows.rs

Line 1313 in 2972b5e

let err = api::get_last_error();

-- could we reuse some of that? Is there an opportunity to use MoveFileExW for this path at all?

MoveFileExW operates exclusively on filenames. Dir::rename is intended to be TOCTOU-safe, so it needs to use directory Handles. I've factored out the NtSetInformationFile section of both functions into nt_rename. The implementations are a little different from one another, so I'm not 100% sure I got the function signature right. I'll wait for the CI to run and reevaluate.

Qelxiros · 2026-07-15T03:48:13Z

I am still interested in working on this; I had changes for the previous review in my local repo, but I forgot to push them.

rustbot · 2026-07-15T03:52:24Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

RalfJung · 2026-07-15T06:34:47Z

Remember to @rustbot ready when this is ready for review again, i.e., after you incorporated all feedback.

Qelxiros · 2026-07-15T12:24:07Z

@rustbot ready

Mark-Simulacrum · 2026-07-16T12:24:20Z

@bors squash msg="add file operations to std dirfd"

rust-bors · 2026-07-16T12:24:44Z

🔨 3 commits were squashed into b6849b3.

Mark-Simulacrum · 2026-07-16T12:39:04Z

@bors r+ rollup=iffy

rust-bors · 2026-07-16T12:39:07Z

📌 Commit b6849b3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…acrum dirfd file operations (2/4) Previous PR: rust-lang#146341 Reference: rust-lang#139514 Tracking issue: rust-lang#120426

…uwer Rollup of 18 pull requests Successful merges: - #150679 (dirfd file operations (2/4)) - #158758 (Rename `lazy_type_alias` feature gate to `checked_type_aliases` ) - #159177 (Explicitly materialize debuginfo tests for all debuggers) - #159392 (Update Rust crate rand to v0.9.3 [SECURITY]) - #159393 (Update Rust crate rkyv to v0.8.16 [SECURITY]) - #159394 (Update Rust crate tar to v0.4.46 [SECURITY]) - #159395 (Update Rust crate tracing-subscriber [SECURITY]) - #159193 (Port compiletest's CLI to clap) - #158992 (Shorten types more when only interesting part is lifetimes) - #159226 (Track extra_lifetime_params_map per-owner) - #159273 (tidy: document u64 limit for numeric sort keys) - #159322 (Fix safety doc in intrinsics::simd) - #159329 (Fix the stale metrics directory warning) - #159357 (Add regression tests for two fixed issues) - #159360 (Remove FIXMEs referencing #44232) - #159375 (make a couple codegen-llvm tests compatible with 2021 edition) - #159381 (emit `(lldb)` prefix to make commands more distinct) - #159396 (Update actions/checkout action to v7)

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#150679 (dirfd file operations (2/4)) - rust-lang/rust#158758 (Rename `lazy_type_alias` feature gate to `checked_type_aliases` ) - rust-lang/rust#159177 (Explicitly materialize debuginfo tests for all debuggers) - rust-lang/rust#159392 (Update Rust crate rand to v0.9.3 [SECURITY]) - rust-lang/rust#159393 (Update Rust crate rkyv to v0.8.16 [SECURITY]) - rust-lang/rust#159394 (Update Rust crate tar to v0.4.46 [SECURITY]) - rust-lang/rust#159395 (Update Rust crate tracing-subscriber [SECURITY]) - rust-lang/rust#159193 (Port compiletest's CLI to clap) - rust-lang/rust#158992 (Shorten types more when only interesting part is lifetimes) - rust-lang/rust#159226 (Track extra_lifetime_params_map per-owner) - rust-lang/rust#159273 (tidy: document u64 limit for numeric sort keys) - rust-lang/rust#159322 (Fix safety doc in intrinsics::simd) - rust-lang/rust#159329 (Fix the stale metrics directory warning) - rust-lang/rust#159357 (Add regression tests for two fixed issues) - rust-lang/rust#159360 (Remove FIXMEs referencing rust-lang/rust#44232) - rust-lang/rust#159375 (make a couple codegen-llvm tests compatible with 2021 edition) - rust-lang/rust#159381 (emit `(lldb)` prefix to make commands more distinct) - rust-lang/rust#159396 (Update actions/checkout action to v7)

…crum dirfd dir operations (3/4) Previous PR: rust-lang#150679 Reference: rust-lang#139514 Tracking issue: rust-lang#120426

rustbot assigned tgross35 Jan 4, 2026

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026