Rollup of 4 pull requests - #152091
Closed
JonathanBrouwer wants to merge 11 commits into
Closed
Conversation
It's a tiny module with one trait and a default impl. It's not used in `rustc_query_system`; all uses and non-default impls are in `rustc_middle` and `rustc_query_impl`. This commit moves it into `rustc_middle`, which makes things simpler overall.
It's a better place for it, because it relates to queries.
They are defined in `rustc_query_system` but used in `rustc_query_impl`. This is very much *not* how things are supposed to be done; I suspect someone got lazy and took a shortcut at some point. This commit moves the errors into `rustc_query_impl`. This requires more lines of code to give `rustc_query_impl` an errors module, but it's worthwhile to do things in the normal way instead of a weird exceptional way.
It's unused. And it's nice to remove this function that didn't behave like normal `clear` does, as the comment explained.
Extend CI postprocessing to aggregate pass/fail/ignored counts for debuginfo tests. Tests are identified via their reported suite names (e.g. debuginfo-gdb, debuginfo-lldb or debuginfo-cdb). Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Some `rustc_query_system` cleanups Small improvements I found while looking closely at `rustc_query_system`. Best reviewed one commit at a time. r? @cjgillot
…obzol citool: report debuginfo test statistics Extend CI postprocessing to aggregate pass/fail/ignored counts for debuginfo tests. Tests are identified via their reported suite names (e.g. debuginfo-gdb, debuginfo-lldb or debuginfo-cdb).
…alysis, r=jdonszelmann Convert to inline diagnostics in `rustc_pattern_analysis` For rust-lang#151366 r? @jdonszelmann
…ze, r=jdonszelmann Convert to inline diagnostics in `rustc_monomorphize` For rust-lang#151366 r? @jdonszelmann
rustbot
added
A-CI
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_query_systemcleanups #152023 (Somerustc_query_systemcleanups)rustc_pattern_analysis#152070 (Convert to inline diagnostics inrustc_pattern_analysis)rustc_monomorphize#152072 (Convert to inline diagnostics inrustc_monomorphize)r? @ghost
Create a similar rollup