Skip to content

Rollup of 8 pull requests - #152135

Closed
JonathanBrouwer wants to merge 16 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-7mXrFhq
Closed

Rollup of 8 pull requests#152135
JonathanBrouwer wants to merge 16 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-7mXrFhq

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost

Create a similar rollup

Ozzy1423 and others added 16 commits February 4, 2026 07:59
…=lqd

Convert to inline diagnostics in `rustc_resolve`

For rust-lang#151366
Port reexport_test_harness_main to attr parser

Tracking issue: rust-lang#131229

I don't think I can use the parsed form in compiler/rustc_builtin_macros/src/test_harness.rs since that has to use the AST attrs?

r? @JonathanBrouwer
…st_lowering, r=JonathanBrouwer

Convert to inline diagnostics in `rustc_ast_lowering`

Part of rust-lang#151366.

r? @JonathanBrouwer
…jdonszelmann

Convert to inline diagnostics in `rustc_expand`

For rust-lang#151366
r? @jdonszelmann
…orm, r=jdonszelmann

Convert to inline diagnostics in `rustc_mir_transform`

For rust-lang#151366
r? @jdonszelmann
…etadata, r=JonathanBrouwer

Convert to inline diagnostics in `rustc_metadata`

Part of rust-lang#151366.

r? @JonathanBrouwer
…ky, r=GuillaumeGomez

Remove rustdoc GUI flaky test

Part of rust-lang#93784.

Originally, this test was checking more things (original version is [here](rust-lang@6bbbff5)), now it only checks that the `searchIndex` variable is global. However, we already are forced to check it in the `rustddoc-js[-std]` testsuites so I think it's safe to say that it's superfluous and definitely not worth all the CI flakyness it created.

r? ghost
…a, r=jdonszelmann

Convert to inline diagnostics in `rustc_codegen_ssa`

For rust-lang#151366
r? @jdonszelmann
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Feb 4, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Feb 4, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b0c7220 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Feb 4, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #152068 (Convert to inline diagnostics in `rustc_resolve`)
 - #152090 (Port reexport_test_harness_main to attr parser)
 - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`)
 - #152108 (Convert to inline diagnostics in `rustc_expand`)
 - #152114 (Convert to inline diagnostics in `rustc_mir_transform`)
 - #152115 (Convert to inline diagnostics in `rustc_metadata`)
 - #152116 (Remove rustdoc GUI flaky test)
 - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`)

Failed merges:

 - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`)
 - #152106 (Convert to inline diagnostics in `rustc_ast_passes`)
 - #152109 (Convert to inline diagnostics in `rustc_errors`)
 - #152119 (Convert to inline diagnostics in `rustc_middle`)
 - #152126 (Convert to inline diagnostics in `rustc_mir_build`)
 - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 4, 2026
@rust-bors

rust-bors Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 59ec534 failed: CI. Failed job:

@Zalathar

Zalathar commented Feb 5, 2026

Copy link
Copy Markdown
Member

Couldn't fetch log, so the failure is probably bogus.

I'll close this and make a fresh rollup to incorporate some newer approvals.

@Zalathar Zalathar closed this Feb 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2026
@JonathanBrouwer
JonathanBrouwer deleted the rollup-7mXrFhq branch August 21, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants