Migrate libraries from ptr::slice_from_raw_parts to .cast_slice

[Paladynee]

View all comments

Tracking issue for #![feature(ptr_cast_slice)]: #149103
This commit updates most callsites of ptr::slice_from_raw_parts within ./library to the more concise but unstable postfix .cast_slice() method on raw pointers, using the ptr_cast_slice feature. Some tests in alloctests have also been updated.

No functional change, debatably improved readability.

[rustbot]

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

[rustbot]

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: libs
• libs expanded to 7 candidates
• Random selection from Mark-Simulacrum, jhpratt, nia-e

[Paladynee]

some notable places like core::slice::from_raw_parts have not been updated, because i felt like changing that would harm readability than improving it.

[Paladynee]

hmm wait let me revert that doc change, apparently it is exactly the same in std::ptr::slice_from_raw_parts. this is all so confusing since all the names are super similar lol

[xtqqczze]

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

[jhpratt]

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

Aside from this, r=me

[jhpratt]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[Paladynee]

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

i believe they are equivalent other than the debug UB assertion, yes

[Paladynee]

I'm not touching anything in;

• coretests
• core::slice
• any ptr::slice_from_raw_parts{_mut} call in stable documentations
• believe i can revert the stdarch thing since it seems too complicated for me to change for now

with that, i think this pr is ready

@rustbot ready

[xtqqczze]

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

The library/core/src/slice/sort/shared/smallsort.rs changes should be reverted as they conflict with #156192.

[Paladynee]

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

The library/core/src/slice/sort/shared/smallsort.rs changes should be reverted as they conflict with #156192.

done

[jhpratt]

@bors r+ rollup

[rust-bors]

📌 Commit 14315f9 has been approved by jhpratt

It is now in the queue for this repository.

[rust-bors]

💔 Test for bce7e50 failed: CI. Failed job:

• auto - test-various (web logs, enhanced plaintext logs)

[xtqqczze]

Apparently this file requires changes:

rust/tests/mir-opt/inline/inline_shims.drop.Inline.panic-abort.diff

Lines 39 to 42 in 3e353d7

	+ scope 13 (inlined slice_from_raw_parts_mut::<A>) {
	+ scope 14 (inlined std::ptr::from_raw_parts_mut::<[A], A>) {
	+ }
	+ }

[Paladynee]

i ran all tests with --bless and the only change was that file, pushed the changes

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Paladynee]

@rustbot ready

[Paladynee]

any updates? @jhpratt

[jhpratt]

Sorry, I was travelling Europe for the past couple weeks :)

@bors r+

[rust-bors]

📌 Commit cd1f625 has been approved by jhpratt

It is now in the queue for this repository.