Rollup of 16 pull requests - #158828
Closed
JonathanBrouwer wants to merge 72 commits into
Closed
Conversation
Update syntax of try build delegation in bors
do not use title case for section names
do not use title case for section names (part 2)
This updates the rust-version file to 7fb284d.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@7fb284d Filtered ref: rust-lang/rustc-dev-guide@4c2f655 Upstream diff: rust-lang/rust@8c75e93...7fb284d This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
update autodiff install docs for nix
Fix typo in best-practices.md
`Interned` does pointer equality/hashing, which is valid in two cases. - The values are guaranteed to be unique (e.g. via interning, or construction). This is how `rustc_middle` uses `Interned`. - The type has "identity" and different values should be considered distinct even if they are identical. This is how `rustc_resolve` uses `Interned`. PR 137202 tried to clarify things by adding a `T: Hash` constraint to `Interned<'a, T>`. This constraint isn't actually used, because `Interned` is hashed based on pointer value, not contents. But it was intended to communicate the idea that a type stored in `Interned` is actually interned, which is likely to be done with hashing. Panicking impls of `Hash` were added for the relevant `rustc_resolve` types to work around the fact that it doesn't use hashing-based interning. In my opinion PR 137202 didn't improve things. The `T: Hash` constraint is only aimed at the interning case, and even for that case it's not quite right because you could use a `BTreeMap` to intern instead of a `HashMap`. This commit does several things. - Removes the `T: Hash` constraint and the `Hash` impls for `rustc_resolve` types added in PR 137202. - Improves the comments on `Interned` to cover the non-interning cases. - Removes the `PartialOrd`/`Ord` impls on `Interned` because (a) they're not used, and (b) their meaning is unclear for the "identity" case. - Improves the documentation in `rustc_resolve` to explain how `Interned` usage is valid there.
update `FIXME(static_mut_refs)` comment to say: use raw pointers instead of references.
This is more robust then assuming it's in Program Files. We still fallback to Program Files as a last resort.
Because we use `ThinVec` rather than `Vec` almost everywhere else in the AST.
Because we use `ThinVec` rather than `Vec` almost everywhere else in the AST.
The unstable attribute on Read::read_le and Read::read_be pointed to the implementation PR rather than the tracking issue, so the docs on doc.rust-lang.org linked to the wrong page.
…n-ident, r=JonathanBrouwer Fix ICE on non-ident path in `doc(auto_cfg values)` Fixes rust-lang#158744 `#[doc(auto_cfg(hide(a, values(::b))))]` could ICE while parsing `values(...)` because the malformed nested meta item did not have a single identifier, but the error path still called `unwrap()` on `sub_item.ident()`.
…overage, r=jhpratt library: expand HashSet::extract_if coverage adds separate `HashSet::extract_if` tests for empty input, consuming no elements & consuming all elements. the existing test covered one element `true`/`false` predicates but did not check the empty case or the yielded elements when everything is extracted so this keeps the coverage focused on normal public behavior & avoids testing post panic iterator behavior. Tested: - `python x.py fmt --check` - `git diff --check`
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@8d488c6. Created using https://github.com/rust-lang/josh-sync. r? @ghost
…-alloc-error, r=RalfJung Add regression test for CString::clone_into unwind safety Regression test for the panic-safety fix in rust-lang#155707 rust-lang#70201 gave `<CStr as ToOwned>::clone_into` a path that moved the target `CString`'s buffer out (leaving it empty) before growing a `Vec`; if that growth's allocation failed and unwound, the target was left without its nul terminator, which is UB. rust-lang#155707 fixed this but didn't add a test. The failing allocator here is only honored under Miri - in a normal build a `#[global_allocator]` in a library test doesn't intercept the reallocation inside `CString::clone_into` (it lives in libstd, linked `-C prefer-dynamic`). So the test passes as a regular test and does the real check under Miri, with the unwind assertion gated on `cfg!(miri)`; it runs under Miri in CI via the library-tests-under-Miri job. This started as rust-lang/miri#5157, but per @RalfJung a std regression test belongs with the standard library. r? @RalfJung
Fix typo Extracted out of rust-lang#155438
rustbot
added
A-attributes
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 5, 2026
Rollup of 16 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Zforce-intrinsic-fallbackflag #158377 (add-Zforce-intrinsic-fallbackflag)current_exefor OpenBSD #158183 (std: allocate less memory incurrent_exefor OpenBSD)FIXME(static_mut_refs)comments #158730 (UpdateFIXME(static_mut_refs)comments)tests/ui/issues[18/N] #158752 (Reorganizetests/ui/issues[18/N])ThinVecmore in the AST #158755 (UseThinVecmore in the AST)read_le/read_be#158757 (Fix incorrect tracking issue forread_le/read_be)doc(auto_cfg values)#158765 (Fix ICE on non-ident path indoc(auto_cfg values))r? @ghost
Create a similar rollup