Skip to content

Rollup of 2 pull requests - #161143

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-hgQTzZ3
Aug 15, 2026
Merged

Rollup of 2 pull requests#161143
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-hgQTzZ3

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Aug 15, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

RalfJung and others added 4 commits August 15, 2026 15:09
@RalfJung
fix buggy MaybeDangling<&T> validation logic
73d3b1c
@amirHdev
Add regression test for assumptions-on-binders ICE
4fab3c1 
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@JonathanBrouwer
Rollup merge of rust-lang#161125 - RalfJung:MaybeDangling-validity, r…
337eccf 
…=saethlin

fix buggy MaybeDangling<&T> validation logic

Fixes a critical regression in rust-lang#160749.
This is what caused the trouble in rust-lang/miri#5252.
r? @oli-obk or @saethlin
@JonathanBrouwer
Rollup merge of rust-lang#159971 - amirHdev:fix-missing-placeholder-a…
1b0402d 
…ssumptions, r=jackh726

Add regression test for rust-lang#159890

Adds regression coverage for rust-lang#159890

The ICE no longer reproduces after the canonical response universe assumptions fix landed. this keeps the original reproducer as a UI test and checks that it reports the expected E0195 and E0046 diagnostics instead of panicking

Closes rust-lang#159890
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Aug 15, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 15, 2026
@JonathanBrouwer

JonathanBrouwer commented Aug 15, 2026

Copy link
Copy Markdown
Member Author

@bors r+ p=5

@rust-bors

rust-bors Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1b0402d has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2026
@rust-bors

rust-bors Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 12m 50s
Pushing 67854e5 to main...

@rust-bors
rust-bors Bot merged commit 67854e5 into rust-lang:main Aug 15, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 15, 2026
@rust-timer

rust-timer commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#161125 fix buggy MaybeDangling<&T> validation logic 62dfa33f21e950f180ab0ddbe907cf312851777a (link)
#159971 Add regression test for #159890 a923806a896938e6dbe21dd6891d9531cc3bbe46 (link)

previous master: c9b7f17889

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-bors rust-bors Bot mentioned this pull request Aug 15, 2026
Open
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c9b7f17 (parent) -> 67854e5 (this PR)

Test differences

Show 9 test diffs

Stage 1

  • [ui] tests/ui/assumptions_on_binders/missing-placeholder-assumptions-issue-159890.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/assumptions_on_binders/missing-placeholder-assumptions-issue-159890.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/assumptions_on_binders/missing-placeholder-assumptions-issue-159890.rs: [missing] -> pass (J1)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 67854e511de21d881bb16426996cd4259d44aa2e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-linux: 1h 21m -> 1h 53m (+39.0%)
  2. test-various: 1h 25m -> 1h 58m (+38.1%)
  3. x86_64-gnu-llvm-22-2: 1h 9m -> 1h 31m (+32.2%)
  4. x86_64-gnu-stable: 2h 24m -> 1h 38m (-32.1%)
  5. dist-various-2: 45m 2s -> 31m 47s (-29.4%)
  6. x86_64-gnu-llvm-21-2: 1h 31m -> 1h 4m (-29.4%)
  7. dist-various-1: 46m 37s -> 33m 19s (-28.5%)
  8. dist-x86_64-linux-alt: 1h 47m -> 2h 16m (+26.3%)
  9. x86_64-gnu-llvm-22-1: 1h 10m -> 52m 22s (-26.0%)
  10. x86_64-gnu-tools: 49m 15s -> 36m 27s (-26.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (67854e5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.7%, -0.2%] 7
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 4.2%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 4.2% [4.2%, 4.2%] 1
Regressions ❌
(secondary)		 1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.2% [4.2%, 4.2%] 1

Cycles

Results (secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [2.8%, 4.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.6% [-8.7%, -2.0%] 5
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.034s -> 459.382s (0.29%)
Artifact size: 398.93 MiB -> 396.87 MiB (-0.52%)

@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#161125 fix buggy MaybeDangling<&T> validation logic b2712e373e7371a2054644e6f46b20187b86eb00
(link)
#159971 Add regression test for #159890 beb665a17cef28c0a1a1d320c9ea00626a84b8de
(link)

parent commit: c9b7f17889

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@JonathanBrouwer
JonathanBrouwer deleted the rollup-hgQTzZ3 branch August 21, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rust-timer @rustbot @RalfJung @amirHdev