move some attribute related structs out of rustc_attr_ir

[mejrs]

This changes it so that

• rustc_session no longer depends on rustc_attr_ir
• rustc_attr_ir no longer depends on rustc_target (which is a fairly sizeable crate)
• rustc_attr_ir and rustc_target can compile in parallel

Previous graph:

Graph with this PR:

r? @JonathanBrouwer

[rustbot]

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

rustc_error_messages was changed

cc @TaKO8Ki

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

[rustbot]

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[JonathanBrouwer]

^ Rebased, rustc_session is now also unused in clippy_lints

[JonathanBrouwer]

This change is great, the only thing I'm iffy about is the name rustc_structures. The name is accurate because it's basically a lot of structs that don't have anything in common stuffed into a crate, but I'm also not sure how to feel about this concept.

I can't think of a better name and I don't want to start a bikeshedding session, so let's merge this if it improves bootstrap times, I'll do some measurements locally

View changes since the review

[JonathanBrouwer]

On my pc running rm -r build/x86_64-unknown-linux-gnu/stage1-rustc; ./x check compiler/rustc_middle, average of 5 measurements:

• before this 14.1s
• after this 13.4s

[JonathanBrouwer]

@bors r+ p=1 note=bitrotty

[rust-bors]

📌 Commit cf98f58 has been approved by JonathanBrouwer

It is now in the queue for this repository.