Add safety comments in alloc::Wtf8 - #161292
Open
yilin0518 wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
yilin0518
force-pushed
the
fix_alloc_wtf8
branch
from
August 18, 2026 11:45
4db724d to
98f6449
Compare
yilin0518
changed the title
clarfonthey
reviewed
Aug 18, 2026
yilin0518
force-pushed
the
fix_alloc_wtf8
branch
from
August 18, 2026 16:37
98f6449 to
4735b8c
Compare
clarfonthey
reviewed
Aug 21, 2026
| use crate::vec::Vec; | ||
|
|
||
| /// An owned, growable string of well-formed WTF-8 data. | ||
| /// An owned, growable string of [well-formed WTF-8](https://wtf-8.codeberg.page/#well-formed) data. |
Contributor
There was a problem hiding this comment.
Would you mind updating the links in core::wtf8 to use this link as well? Currently they link to Simon's GitHub repo, which appears to be an older version.
Contributor
Author
There was a problem hiding this comment.
No problem, I can fix these links.
Contributor
|
Thank you! One small comment about updating the links so they match, otherwise looks good to me. |
yilin0518
force-pushed
the
fix_alloc_wtf8
branch
from
August 21, 2026 14:17
4735b8c to
8fe7ae5
Compare
Contributor
Author
|
@clarfonthey I have update the links in core::Wtf8, you can take a look. Thank you for your review! |
Contributor
|
Thank you! @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
…nthey Add safety comments in alloc::Wtf8 This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824. Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core. I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
…nthey Add safety comments in alloc::Wtf8 This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824. Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core. I'm looking forward to your review and give me any feedback to improve this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follow up #160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every
Untrigedmentioned in #160824.Before this PR, #161271 had add some safety sections for Wtf8 in core.
I'm looking forward to your review and give me any feedback to improve this PR.