Rollup of 25 pull requests - #161383
Closed
JonathanBrouwer wants to merge 74 commits into
Closed
Conversation
This patch implements Rust's equivalent of Clang's function pointer type discriminator computation used in pointer authentication. Compatibility with Clang is a primary goal. The discriminator produced for a given external "C" function type must match the value computed by Clang so that function pointers can be exchanged safely between Rust and C code while preserving pointer authentication semantics. The implementation mirrors Clang's behavior in `ASTContext::encodeTypeForFunctionPointerAuth`, ensuring that identical C-compatible function types produce identical discriminators. See: <https://clang.llvm.org/doxygen/ASTContext_8cpp.html#abb1375e068e807917527842d05cadea3>.
atomic volatile: add intrinsics Extend the atomic load/store intrinsics to also support volatile atomic load/store. Tracking issue: rust-lang#158947. Library APIs that use these intrinsics will be added inn a future PR. The GCC and cranelift implementations ignore the volatile flag, not sure how that should be implemented for them.
To `QuerySystem`, next to `query_vtables`. It's a better spot for it.
`MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead.
…=davidtwco remove unwrap from write_mir_fn_graphviz
Enhance EII UI tests The first commit enabled all EII tests on Windows MSVC. Two other PRs were merged almost simultaneously with my previous PR and they kept `ignore-windows` instead of `ignore-windows-gnu`. The second commit normalized EII dylib test coverage. Previously, there were only two dedicated negative tests and some auxiliary crates that had `no-prefer-dynamic` removed but whose `crate_type` was still `rlib` were accidentally compiled into `dylib`s and thus were tested unintentionally. This is now normalized: some tests will be tested under two revisions: `rlib` and `dylib` or `dylib-impl` (declaration in `rlib` & implementation in `dylib`). Note that `call_default_panics.run.stderr` is not updated; the file appears to be invalid, and I am unsure how to update this check.
…dtwco fix arm homogeneous aggregate ABI This started with abi-cafe finding a mismatch between rustc and clang/gcc, but turned into quite the rabbit hole of bits of ABI that were never implemented. The code is effectively ported from LLVM, and abi-cafe is happy now. The bug I hit was that aligned structs were passed incorrectly: https://godbolt.org/z/jErPoPrv5 The assertions for watchOS are best-effort, I can't actually run that. But, it's tier 3, it was already broken, so at worst it's just less broken now. The relevant code is in https://github.com/llvm/llvm-project/blob/551766823bb7b5a6af84e4ec1c1aff6dff431229/clang/lib/CodeGen/Targets/ARM.cpp, I'll link some specific parts. r? davidtwco
fix crash in async-drop and async-gen handle `AsyncGenPending` constants in `FixReturnPendingVisitor` rewrite `AsyncGenPending` constant uses to `Poll::<()>::Pending` in `FutureDropPoll` shims, matching the existing aggregate path also added a regression test fixes rust-lang#161101. issue reproduce - https://godbolt.org/z/d1zb4j974
Download auto jobs in citool in parallel To make the post-merge workflow report the result sooner after a PR is merged, and also to make local experiments (also with the test dashboard) quicker. r? jieyouxu
Reserve capacity for 3% anon nodes This reserves capacity for 3% anon nodes instead of 100%. For the benchmark suite the mean is ~1.6% and max ~5.8%, so I picked a middle ground.
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
Rename `ProjectionPredicate` and `TraitPredicate` Part of rust-lang#107250 This deviates from the plan I described in rust-lang#107250 (comment). The reason is that I kept getting into the awkward situation where I would go into a function dealing with multiple predicate/clause kinds, and need to rename only the variables referring with the particular kind I was renaming. So now, the plan is to first rename only the types (this PR), and afterwards go into functions and rename all the variables in them at once. That would also allow splitting the work better, e.g. tackling one crate/subtree at a time. r? @oli-obk
add relnotes 1.98.0 r? @cuviper cc @rust-lang/release
Remove a bunch of unnecessary explicit lifetimes Both rustdoc and hir ty lowering only process the HIR, they never store any of those nodes anywhere. The reason I did this is that I'm refactoring `hir::ItemKind::Use`, and for rustdoc's processing of it it is more convenient to create a bunch of values on the stack and reference them, but right now rustdoc was expecting `'tcx` lifetimes everywhere.
…tor,davidtwco make ARM maintainers pingable rust-lang#153720 added the suggestion to ping ARM maintainers via rustbot, but that doesn't actually work currently. I hope this is the right way to set up triagebot. Also, the target pages make it look like there is a `@rust-lang/arm-maintainers` GH team, which does not actually exist. Cc @davidtwco
…r=Nadrieril Add regression test for rustc diagnostic to recognize variables in match guards closes rust-lang#80954
Don't rely on std traits not being const in tests Many of these were dealt with in rust-lang#155616 There are some remaining ones r? @oli-obk
vec: fixup the name that i forgot Forgot this in rust-lang#161115. per libs decision in rust-lang#158344
…jorn3 Reflect current PR title names for subtree syncs in triagebot no-merges Noticed that the current PR title names for subtree syncs seems to have changed (or at least for some) and is now "Subtree sync" (or it's lower-cased variant). Let's update the triagebot config so the merge commit handler don't for those expected cases. - rust-lang#157533 (comment) - rust-lang#155978 (comment)
rustbot
added
the
S-waiting-on-review
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
Rollup of 25 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
Contributor
Member
Author
|
@bors p=10 |
Member
Author
|
@bors p=9 |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc-perfsubmodule #161344 (Update therustc-perfsubmodule)GlobalCtxt/Sessioncleanups #161332 (SomeGlobalCtxt/Sessioncleanups)#[repr(transparent)]if#[rustc_pub_transparent]is applied #150931 (rustdoc: Always document#[repr(transparent)]if#[rustc_pub_transparent]is applied)remove hidden_glob_reexports item breaks downstreamtest #160582 (Addremove hidden_glob_reexports item breaks downstreamtest)TargetOptions::llvm_abiname#161283 (Tighten the language used for documentingTargetOptions::llvm_abiname)ProjectionPredicateandTraitPredicate#161291 (RenameProjectionPredicateandTraitPredicate)r? @ghost
Create a similar rollup