Rollup of 20 pull requests - #161458
Open
jhpratt wants to merge 58 commits into
Open
Conversation
- be explicit when only needing types of `GenericArgs`
…nthey doc: document safety requirements for core WTF-8 This PR is a follow-up to rust-lang#160824, and serves as a complementry of `Wtf8` in `alloc` . This PR currently fixes the wtf8 module in `core`, because I noticed that some unsafe APIs in this file do not provide a `safety section`. Therefore, before discharging the call sites, we need to first add the safety section. This PR performs that fix. This PR is related to unstable feature `Wtf8` but this feature don't have relevant tracking issue.
LLVM 24: configure float-abi via module flag `TargetOptions::FloatABIType` was removed in llvm/llvm-project#215796 See llvm/llvm-project#212985 for the corresponding clang change. The `ModuleFlagMergeBehavior::Error` was copied from the clang implementation. This currently relies on the string representation of Rust's [`FloatAbi` "target_spec_enum"](https://github.com/rust-lang/rust/blob/e71c0f1e3395b10a8c331317be1a5c107bdf7b2e/compiler/rustc_target/src/spec/mod.rs#L978-L986) matching LLVM. This seemed reasonable to me since the representation is quite straightforward ("soft" and "hard"), but let me know if you'd like an explicit `to_llvm_float_abi_str`, either defined in Rust or forwarding to `llvm::FloatABI::getABITypeName`. Contrary to the clang implementation which only sets the module flag if it differs from the target default, we set it whenever the Rust target has an explicit float ABI set. See also discussion in [#t-compiler/llvm > float-abi module flag behavior](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fllvm/topic/float-abi.20module.20flag.20behavior/with/617279073). The added test won't actually run on Rust's own CI until that updates to LLVM 24. @rustbot label llvm-main
Only suggest `RUST_MIN_STACK` if maybe stack overflow Alternatively we could make the wording of the help message note the uncertainty.
…r=TaKO8Ki Add regression test for confusing lifetime error message issue closes rust-lang#79033
Configure LLM policy URL for triagebot Implemented in rust-lang/triagebot#2486, documented in rust-lang/rust-forge#1099. CC @jyn514 r? Urgau
splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB Fixes rust-lang#161323. Miri previously reported UB when running this test, and LLVM 24 treated it as UB. r? @teor2345 I'm not sure what _exactly_ is getting tested here, but based on your comment on the issue I assume that moving these to a `let` binding is fine.
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
…=GuillaumeGomez Fix rustdoc remapping `documentation` scope documentation We have `--remap-path-scope` since rust-lang#155451, the documentation is outdated.
…nia-e Update expect messages in path docs to better follow guidelines Updates the `.expect()` messages in `library/std/src/path.rs` to better follow the guidance for `expect` messages. Related to rust-lang#159751.
Change triagebot backport to ping T-libs-fcp Discussed in https://rust-lang.zulipchat.com/#narrow/channel/542373-t-libs.2Fbackports/topic/.23161430.3A.20beta-nominated/with/617851159. r? @nia-e
…Brouwer Add regression test for dead code on type alias used in impl self type Closes rust-lang#59333
rustbot
added
A-attributes
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit f2667ec with merge bb2190b… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/32483325476 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-* try-job: x86_64-mingw-1 try-job: i686-msvc-*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
FnKind, minor refactorings #160853 (delegation: simplify matches onFnKind, minor refactorings)GenericArgs::typestriage + possible fixes #159899 (GenericArgs::typestriage + possible fixes)deprecatedattribute checking #160459 (Use attribute parser fordeprecatedattribute checking)String::into_raw_partsand reusefrom_utf16optimization #160536 (InlineString::into_raw_partsand reusefrom_utf16optimization)BorrowedCursor<'a, T>covariant in'aand drop an indirection #160563 (MakeBorrowedCursor<'a, T>covariant in'aand drop an indirection)str::split_atdocs #160595 (Clarifystr::split_atdocs)RUST_MIN_STACKif maybe stack overflow #161320 (Only suggestRUST_MIN_STACKif maybe stack overflow)letto avoid UB #161403 (splat-fn-ptr-ptr-tuple.rs: addletto avoid UB)tests/rustdoc-gui/notable-trait.gomltest #161409 (Add backtests/rustdoc-gui/notable-trait.gomltest)documentationscope documentation #161410 (Fix rustdoc remappingdocumentationscope documentation)Failed merges:
RegionExt; move methods toRegioninrustc_type_ir#160509 (RemoveRegionExt; move methods toRegioninrustc_type_ir)r? @ghost
Create a similar rollup