Rollup of 19 pull requests by JonathanBrouwer · Pull Request #161505 · rust-lang/rust

JonathanBrouwer · 2026-08-22T08:48:46Z

Successful merges:

Build rustc and codegen backends with -Zembed-metadata=no #151061 (Build rustc and codegen backends with -Zembed-metadata=no)
Error on projection of dyn noncompat type in old trait solver #154992 (Error on projection of dyn noncompat type in old trait solver)
Allow self in const generics #157949 (Allow self in const generics)
trait_selection: fix assumptions-on-binders diagnostics #158588 (trait_selection: fix assumptions-on-binders diagnostics)
core: implement float conversion methods #159954 (core: implement float conversion methods)
Add Default implementation for std::sync::Once #160136 (Add Default implementation for std::sync::Once)
resolver diagnostics: don't swallow labels and point out similar items as a note, not a label #160835 (resolver diagnostics: don't swallow labels and point out similar items as a note, not a label)
Improve the ABI between the panic runtime and libstd #161048 (Improve the ABI between the panic runtime and libstd)
Add safety comments in alloc::Wtf8 #161292 (Add safety comments in alloc::Wtf8)
Add some rustc_type_ir comments #161444 (Add some rustc_type_ir comments)
Remove leftover immediate creation #161465 (Remove leftover immediate creation)
Add Arc/Rc::strong_count_from_raw #159098 (Add Arc/Rc::strong_count_from_raw)
Update documentation for -Zdump-dep-graph #159282 (Update documentation for -Zdump-dep-graph)
Remove fields from TypeKind: Bool, Char, Float and Int #161401 (Remove fields from TypeKind: Bool, Char, Float and Int)
bootstrap: (offload) be stricter about selected compiler and paths #161431 (bootstrap: (offload) be stricter about selected compiler and paths)
Avoid arming the Windows TLS destructor guard in fibers #161451 (Avoid arming the Windows TLS destructor guard in fibers)
Add myself to mailmap #161463 (Add myself to mailmap)
Use bitset for locals_with_use_data #161476 (Use bitset for locals_with_use_data)
Warn about running ui-fulldeps tests in stage 1 #161483 (Warn about running ui-fulldeps tests in stage 1)

Failed merges:

add internal DSL for testing binders #161443 (add internal DSL for testing binders)

The supposed output path was incorrect. Using `-Zdump-dep-graph` does NOT emit to `/tmp/dep_graph.gv`, but to 2 files, one being `dep_graph.txt` and the other `dep_graph.dot` in the current directory

…s as a note, not a label

This requires moving PanicPayload to alloc.

Canonical type-op queries discard NextGen constraints, so function-body failures never reached NLL. Evaluate those ops locally under -Zassumptions-on-binders and preserve the origin span on the resulting outlives constraints.

Keep this branch focused on reporting solver region constraints. The type-op behavior and its borrowck coverage are handled separately.

While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling.

Add some documentation for `rustc_type_ir` and `SolverDelegate`.

`from_immediate` calls left over from refactor d3d3485 can create invalid LLVM IR

These fields served to query the bitwidth for both and whether an integer is signed or not. The bitwith is now provided by `TypeId::bits` while the signedness can be gotten trough the earlier introduces `TypeId::is_signed`.

* Add Arc/Rc::strong_count_from_raw * Drop the global allocator requirement from strong_count_from_raw The clause came from increment_strong_count and decrement_strong_count, where it holds because those rebuild an Arc<T, Global> through from_raw_in and the decrement path frees through the global allocator. Reading the strong count never builds or drops one, and the allocator lives on the Arc rather than in the allocation, so it does not carry over. * std: refine docs for strong_count_from_raw

JonathanBrouwer · 2026-08-22T08:49:08Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=x86_64-gnu-distcheck

rust-bors · 2026-08-22T08:49:11Z

📌 Commit 45cb821 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 19 pull requests try-job: x86_64-gnu-distcheck

rust-bors · 2026-08-22T11:17:19Z

☀️ Try build successful (CI)
Build commit: 8cf0ce3 (8cf0ce3cf5834612d216f38aceebba8e1970e6e8)
Base parent: 8536f4d (8536f4de90e5e781c06e584f8a88de860adc798b)

rust-bors · 2026-08-22T13:29:06Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 10m 42s
Pushing b0ca9c7 to main...

github-actions · 2026-08-22T13:31:52Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing def3ee9 (parent) -> b0ca9c7 (this PR)

Test differences

Show 1430 test diffs

Stage 0

infer::solver_region_constraints::tests::evaluation_is_span_agnostic: [missing] -> pass (J7)
infer::solver_region_constraints::tests::evaluation_preserves_first_ambiguity_span: [missing] -> pass (J7)

Stage 1

[ui] tests/ui/assumptions_on_binders/higher-ranked-outlives-issue-157732.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/allow-self-in-const-generics.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/ban-self-when-feature-not-enabled.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/object/dyn-proj-non-dyn-compat.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/object/dyn-type-param-bound-not-checked.rs#current: [missing] -> pass (J0)
[ui] tests/ui/traits/object/dyn-type-param-bound-not-checked.rs#next: [missing] -> pass (J0)
num::float_conversions::cast_widen_narrow: [missing] -> pass (J2)
num::float_conversions::checked_exact_power_of_two_bounds: [missing] -> pass (J2)
num::float_conversions::checked_signed_boundaries: [missing] -> pass (J2)
num::float_conversions::checked_truncates_then_bounds: [missing] -> pass (J2)
num::float_conversions::f128_checked_fractional: [missing] -> pass (J2)
num::float_conversions::f16_checked_fractional: [missing] -> pass (J2)
num::float_conversions::f16_into_wide_int_accepts_all_finite: [missing] -> pass (J2)
num::float_conversions::saturating_basics: [missing] -> pass (J2)
num::float_conversions::strict_matches_checked: [missing] -> pass (J2)
num::float_conversions::strict_panics_on_nan: [missing] -> pass (J2)
num::float_conversions::strict_panics_on_overflow: [missing] -> pass (J2)
infer::solver_region_constraints::tests::evaluation_is_span_agnostic: [missing] -> pass (J4)
infer::solver_region_constraints::tests::evaluation_preserves_first_ambiguity_span: [missing] -> pass (J4)
[ui (polonius)] tests/ui/assumptions_on_binders/higher-ranked-outlives-issue-157732.rs: [missing] -> pass (J5)
[ui (polonius)] tests/ui/const-generics/allow-self-in-const-generics.rs: [missing] -> pass (J5)
[ui (polonius)] tests/ui/const-generics/ban-self-when-feature-not-enabled.rs: [missing] -> pass (J5)
[ui (polonius)] tests/ui/traits/object/dyn-proj-non-dyn-compat.rs: [missing] -> pass (J5)
[ui (polonius)] tests/ui/traits/object/dyn-type-param-bound-not-checked.rs#current: [missing] -> pass (J5)
[ui (polonius)] tests/ui/traits/object/dyn-type-param-bound-not-checked.rs#next: [missing] -> pass (J5)

Stage 2

num::float_conversions::cast_widen_narrow: [missing] -> pass (J1)
num::float_conversions::checked_exact_power_of_two_bounds: [missing] -> pass (J1)
num::float_conversions::checked_signed_boundaries: [missing] -> pass (J1)
num::float_conversions::checked_truncates_then_bounds: [missing] -> pass (J1)
num::float_conversions::f128_checked_fractional: [missing] -> pass (J1)
num::float_conversions::saturating_basics: [missing] -> pass (J1)
num::float_conversions::strict_matches_checked: [missing] -> pass (J1)
num::float_conversions::strict_panics_on_nan: [missing] -> pass (J1)
num::float_conversions::strict_panics_on_overflow: [missing] -> pass (J1)
[ui] tests/ui/assumptions_on_binders/higher-ranked-outlives-issue-157732.rs: [missing] -> pass (J3)
[ui] tests/ui/const-generics/allow-self-in-const-generics.rs: [missing] -> pass (J3)
[ui] tests/ui/const-generics/ban-self-when-feature-not-enabled.rs: [missing] -> pass (J3)
[ui] tests/ui/traits/object/dyn-proj-non-dyn-compat.rs: [missing] -> pass (J3)
[ui] tests/ui/traits/object/dyn-type-param-bound-not-checked.rs#current: [missing] -> pass (J3)
[ui] tests/ui/traits/object/dyn-type-param-bound-not-checked.rs#next: [missing] -> pass (J3)
num::float_conversions::f16_checked_fractional: [missing] -> pass (J6)
num::float_conversions::f16_into_wide_int_accepts_all_finite: [missing] -> pass (J6)

Additionally, 1386 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b0ca9c712455d865c3bf0bf5325a3e79677a2d97 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-stdlib-semver-check: 13m 27s -> 18m 31s (+37.7%)
dist-various-1: 33m 18s -> 45m 2s (+35.2%)
test-various: 1h 55m -> 1h 14m (-34.8%)
x86_64-gnu-nopt: 2h 25m -> 1h 40m (-31.0%)
i686-gnu-nopt-1: 2h 17m -> 1h 34m (-31.0%)
tidy: 5m 37s -> 7m 13s (+28.5%)
x86_64-gnu-gcc-core-tests: 14m 36s -> 18m 40s (+27.9%)
dist-ohos-armv7: 1h 1m -> 1h 16m (+25.1%)
x86_64-gnu-debug: 1h 42m -> 2h 6m (+23.8%)
dist-x86_64-msvc-alt: 2h 55m -> 2h 15m (-22.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-22T14:12:29Z

Finished benchmarking commit (b0ca9c7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Cycles

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-4.0%, -1.8%]	5
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 468.743s -> 469.195s (0.10%)
Artifact size: 400.28 MiB -> 400.17 MiB (-0.03%)

rust-bors · 2026-08-22T14:35:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151061	Build rustc and codegen backends with -Zembed-metadata=no	`9bb8fdc924320727276502013d7239883f504d4f` (link)
#154992	Error on projection of dyn noncompat type in old trait solv…	`3a9c93056848f13a208bf4d137a81efdad96389e` (link)
#157949	Allow self in const generics	`9930f9f2969974ca46e7fd560581fe287487f2cd` (link)
#158588	trait_selection: fix assumptions-on-binders diagnostics	`d04c6b358f664234fb0d3fa168837527873da51e` (link)
#159954	core: implement float conversion methods	`0b249e080183d161915f2fbd9883d5431ab8af8c` (link)
#160136	Add `Default` implementation for `std::sync::Once`	`f196fe6aedc373609b18bdfeed2b300eb9ebc947` (link)
#160835	resolver diagnostics: don't swallow labels and point out s…	`0bb5cdf73c57ee8f139ab6b14db9e310e73fdf4e` (link)
#161048	Improve the ABI between the panic runtime and libstd	`167e46473b71f7220e5e9c5380d338789672a318` (link)
#161292	Add safety comments in alloc::Wtf8	`429a71bd2cb8ede8504eb578fc17c5feca8eab4b` (link)
#161444	Add some `rustc_type_ir` comments	`54ff6496282f5e5edfb0eba99d4f6efc9c59d6ed` (link)
#161465	Remove leftover immediate creation	`e3db8fa5933d90e64662fce53c1a20b22d16a5ce` (link)
#159098	Add Arc/Rc::strong_count_from_raw	`205c511c3b071a8fbeb1925ef6080014856c6b4d` (link)
#159282	Update documentation for `-Zdump-dep-graph`	`8a9696a8dff428baf969cb78b8a1343ce47ecfe0` (link)
#161401	Remove fields from TypeKind: Bool, Char, Float and Int	`f1b1d7a1d42d8daa6466fc61505b0c88a07eca22` (link)
#161431	bootstrap: (offload) be stricter about selected compiler an…	`037fdd00fe857f843ca3a3d81a92c1d04414bf38` (link)
#161451	Avoid arming the Windows TLS destructor guard in fibers	`7f72f81365f690bc4af4d9f28e622d9e48e95737` (link)
#161463	Add myself to mailmap	`3c1839ea048c0f1ccc4e0ec6296203fd058edffe` (link)
#161476	Use bitset for locals_with_use_data	`5d6d5b50ce3f8006f4996e27e579dd6edd2b4fa3` (link)
#161483	Warn about running ui-fulldeps tests in stage 1	`66195e0d495bad9a8af9f0d874bfb1e119863887` (link)

parent commit: def3ee9e4f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

blyxyas and others added 30 commits July 14, 2026 13:47

Update documentation for -Zdump-dep-graph

1b0230e

The supposed output path was incorrect. Using `-Zdump-dep-graph` does NOT emit to `/tmp/dep_graph.gv`, but to 2 files, one being `dep_graph.txt` and the other `dep_graph.dot` in the current directory

Add Default implementation for std::sync::Once

9ad9fe0

fix

a8d9636

Error on projection of dyn noncompat type in old trait solver

15e32c5

Reduce number of error messages

953e278

Remove more redundant errors

1c18ee4

resolver diagnostics: don't swallow labels and point out similar item…

9ac7293

…s as a note, not a label

imagine developing on windows

0360271

Use Rust ABI for __rust_panic_cleanup

cf0a043

Directly use Box in the PanicPayload trait and __rust_panic_cleanup

8087334

This requires moving PanicPayload to alloc.

Mark PanicPayload and __rust_start_panic as safe

ae5215c

Avoid allocation when using dummy panic_unwind impl

3ef33b7

Mark __rust_drop_panic and __rust_foreign_exception as safe

ffc65e5

Fix assumptions-on-binders outlives diagnostics

32999f2

Generalize solver region constraint spans

2abc0f6

Clarify region constraint span documentation

1c21b08

Keep solver region constraints on the borrowck InferCtxt

b3fb32a

Canonical type-op queries discard NextGen constraints, so function-body failures never reached NLL. Evaluate those ops locally under -Zassumptions-on-binders and preserve the origin span on the resulting outlives constraints.

Bless trailing blank line in alias_outlives stderr

36597f7

Split type-op constraint fix from diagnostics

7bffce8

Keep this branch focused on reporting solver region constraints. The type-op behavior and its borrowck coverage are handled separately.

fix unrecognized link

8b18fda

Build rustc and codegen backends with -Zembed-metadata=no

bbc9e66

While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling.

add some documentation about shared abstraction layer

fa87d61

Add some documentation for `rustc_type_ir` and `SolverDelegate`.

core: implement float conversion methods

3c55beb

Add myself to mailmap

5d347d7

Avoid arming the Windows TLS destructor guard in fibers

373266b

Remove leftover immediate creation

13bf326

`from_immediate` calls left over from refactor d3d3485 can create invalid LLVM IR

Add safety comments in alloc::Wtf8, and update the link in core::Wtf8

8fe7ae5

reflection: remove fields from TypeKind::Int and Float

3c43eb0

These fields served to query the bitwidth for both and whether an integer is signed or not. The bitwith is now provided by `TypeId::bits` while the signedness can be gotten trough the earlier introduces `TypeId::is_signed`.

reflection: remove field from TypeKind::Bool and Char

1d2a65f

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 22, 2026

Auto merge of #161505 - JonathanBrouwer:rollup-IS2Ut1i, r=<try>

8cf0ce3

Rollup of 19 pull requests try-job: x86_64-gnu-distcheck

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2026

rust-bors Bot merged commit b0ca9c7 into rust-lang:main Aug 22, 2026
15 checks passed

rustbot added this to the 1.100.0 milestone Aug 22, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 19 pull requests - #161505

Rollup of 19 pull requests#161505
rust-bors[bot] merged 54 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-IS2Ut1i

JonathanBrouwer commented Aug 22, 2026

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Aug 22, 2026

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 22, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 22, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants