Fix gap in const stability checks around intrinsics - #162409
Open
RalfJung wants to merge 3 commits into
Open
Conversation
Collaborator
|
cc @rust-lang/wg-const-eval Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter |
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
sorry about that 😓 |
N1ark
reviewed
Sep 7, 2026
RalfJung
force-pushed
the
intrinsic-const-stab
branch
from
September 7, 2026 09:17
2d64547 to
bc0851a
Compare
Member
Author
It was me who introduced this bug, you just found it. ;) |
RalfJung
force-pushed
the
intrinsic-const-stab
branch
from
September 7, 2026 09:22
bc0851a to
b3a8050
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
intrinsic-const-stab
branch
from
September 7, 2026 09:30
b3a8050 to
9d60be8
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
intrinsic-const-stab
branch
from
September 7, 2026 10:15
9d60be8 to
022d14a
Compare
RalfJung
commented
Sep 7, 2026
RalfJung
force-pushed
the
intrinsic-const-stab
branch
from
September 7, 2026 10:25
022d14a to
4896f11
Compare
RalfJung
force-pushed
the
intrinsic-const-stab
branch
from
September 7, 2026 10:28
4896f11 to
64752fb
Compare
Member
|
@rustbot reroll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@N1ark managed to find a gap in our const stability checks around intrinsics. This PR fixes that gap.
Sadly the standard library already relies on the gap, so for now I added a
rustc_allow_const_fn_unstablebut that attribute usually needs some process to be approved.