Rollup of 3 pull requests - #162415
Closed
JonathanBrouwer wants to merge 7 commits into
Closed
Conversation
…const_check function
…dingxiangfei2009 Make Receiver `#[rustc_dyn_incompatible_trait]` Fixes: rust-lang#149094 r? dingxiangfei2009
…y-slice, r=oli-obk Remove fields from TypeKind: Array, Slice Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. r? @oli-obk
… r=oli-obk add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function IMO this is crucial, to ensure that we cannot break users by changing the body of such a function to something no-longer-const-compatible. r? @oli-obk
Member
Author
|
@bors r+ p=5 |
Contributor
Contributor
|
This pull request was unapproved due to being closed. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[rustc_dyn_incompatible_trait]#162411 (Make Receiver#[rustc_dyn_incompatible_trait])r? @ghost
Create a similar rollup