Skip to content

Pin the number of frontend threads while gathering PGO to 1 - #162428

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:rustc-perf-profile-one-frontend-thread
Sep 8, 2026
Merged

Pin the number of frontend threads while gathering PGO to 1#162428
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:rustc-perf-profile-one-frontend-thread

Conversation

@Kobzol

@Kobzol Kobzol commented Sep 7, 2026

Copy link
Copy Markdown
Member

This will be important after rust-lang/rustc-perf#2574 is synced here, to avoid running some benchmarks multiple times unexpectedly.

But we can do it proactively, the CLI argument should already be in the in-tree rustc-perf version (hopefully, let's see).

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 7, 2026
@Kobzol

Kobzol commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 7, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
…, r=<try>

Pin the number of frontend threads while gathering PGO to 1
@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: a64f96d (a64f96de799ffa629d4a70cbd84ef42e51386e9b)
Base parent: 656a9da (656a9da186dacaf3bf8f7f7296a825d256cb4ae3)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a64f96d): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.2%, 0.4%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.6% [4.4%, 6.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -0.6%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.7% [0.5%, 0.9%] 6
Regressions ❌
(secondary)
2.7% [2.3%, 3.1%] 2
Improvements ✅
(primary)
-3.1% [-4.7%, -0.6%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-4.7%, 0.9%] 9

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 478.991s -> 479.079s (0.02%)
Artifact size: 403.45 MiB -> 403.45 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 7, 2026
@Kobzol
Kobzol marked this pull request as ready for review September 7, 2026 18:23
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 7, 2026
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@jieyouxu

jieyouxu commented Sep 8, 2026

Copy link
Copy Markdown
Member

Thanks, r=me unless we're waiting for anything else.

@jieyouxu

jieyouxu commented Sep 8, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup=never note="adjusts opt-dist PGO config"

@rust-bors

rust-bors Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 731fd36 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2026
@rust-bors

rust-bors Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 21m 32s
Pushing a3e94c2 to main...

@rust-bors
rust-bors Bot merged commit a3e94c2 into rust-lang:main Sep 8, 2026
15 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6b410a8 (parent) -> a3e94c2 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a3e94c2ff51d6fa9929cf637fd85df3975119801 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-gnu-gcc: 56m 14s -> 1h 25m (+52.2%)
  2. test-x86_64-gnu-llvm-21: 55m 41s -> 35m 11s (-36.8%)
  3. dist-i686-mingw: 1h 4m -> 41m 3s (-36.2%)
  4. dist-ohos-armv7: 56m 21s -> 1h 16m (+35.6%)
  5. dist-x86_64-llvm-mingw: 2h 9m -> 1h 28m (-31.1%)
  6. test-armhf-gnu: 1h 33m -> 1h 8m (-26.2%)
  7. dist-powerpc64-linux-gnu: 1h 37m -> 1h 12m (-25.5%)
  8. test-x86_64-gnu-stdlib-semver-check: 15m 4s -> 11m 34s (-23.2%)
  9. test-x86_64-gnu-parallel-frontend: 1h 18m -> 1h 36m (+23.2%)
  10. test-i686-gnu-nopt-2: 1h 54m -> 2h 20m (+22.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol
Kobzol deleted the rustc-perf-profile-one-frontend-thread branch September 8, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants