Pin the number of frontend threads while gathering PGO to 1 - #162428
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…, r=<try> Pin the number of frontend threads while gathering PGO to 1
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (a64f96d): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 5.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.6%, secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 478.991s -> 479.079s (0.02%) |
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Thanks, r=me unless we're waiting for anything else. |
|
@bors r+ rollup=never note="adjusts opt-dist PGO config" |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6b410a8 (parent) -> a3e94c2 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a3e94c2ff51d6fa9929cf637fd85df3975119801 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This will be important after rust-lang/rustc-perf#2574 is synced here, to avoid running some benchmarks multiple times unexpectedly.
But we can do it proactively, the CLI argument should already be in the in-tree
rustc-perfversion (hopefully, let's see).