Fix ICE emitted when unsized parameters are passed to functions with x86-interrupt ABI. - #162448
Closed
Siech0 wants to merge 1 commit into
Closed
Fix ICE emitted when unsized parameters are passed to functions with x86-interrupt ABI.#162448Siech0 wants to merge 1 commit into
Siech0 wants to merge 1 commit into
Conversation
…x86-interrupt ABI.
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @khyperia (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
I did more thinking about this problem and decided to go about it in a different manner after applying more research. I have opened another PR (#162457), which I believe subsumes this one and handles it more correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve an issue where unsized types could be passed to the x86-interrupt ABI and cause an ICE to be emitted.
Note: There was an update to the note message used when the
extern "tail"abi encounters an error with the same root cause. These behaviors felt correlated enough that adding a note here would be useful to the end users of both. If this is undesirable, reverting this behavior is trivial.Relevant unstable feature: #40180
Fixes #124806
LLM Policy disclaimer: An LLM agent was used in the analysis of the codebase and the self-review of this PR. Specifically, with prompts in the form of:
The addition to suggestions.rs (in the oh-so-helpful way they like to when not asked to) was LLM proposed and human verified. The code was trivial enough that alternatives didn't seem reasonable.