Rollup of 6 pull requests - #162510
Merged
Merged
Conversation
… works for them Limit some `run-make` tests to LLVM until GCC backend works for them
…chsia" This reverts commit 7a44484. This is leading to the issue seen in rust-lang#162272. We're also seeing the same build issues when using a rust toolchain that contains this commit for building fuchsia targets.
…r=Kobzol Make `run-make` testsuite work with other codegen backend than LLVM Needed for rust-lang#159924. Currently, we always run `run-make` testsuite with the codegen backend rustc was compiled with. However, in CI it's compiled with LLVM, so when we want to test with GCC (with `--test-codegen-backend`), it compiles `rmake.rs` with the GCC backend, but when running the test, it doesn't use the GCC backend since it just calls `rustc`. So to get around that, I now pass the codegen backend through the environment and set it in the `rustc` function of `run_make_support`. To be noted that for now it's only for the `rustc` function, no other command uses it. Should I extend it right away for all commands (well, likely only `cargo`) or just `rustc` for now is enough? r? @jieyouxu
Avoid invalid suggestion in case of macro expansion without inferrable generic type Closes rust-lang#129756 . The main challenge for me in this PR was figuring out how to pass down the information of the code being generated from expansion. I went for the simplest approach I could think of, but I questioned myself if the boolean should be placed inside the Visitor. I don't have enough information to figure this out, if it's badly placed I'd be happy to fix and learn! About the test, I split the two commits because we can see the issue being reproduced in the first commit but being fixed on the second. I also added a non-expansion example of the same code to show it won't get altered. Oh, also I didn't know the best place to place the test. I went for the place with same kind of errors, but I guess `proc-macros` could also be a place.
…rochenkov Use correct `dir_path` when parsing module from path Fixes rust-lang#162080 We previously used the incorrect `dir_path` (which was `name`, the parent of `name/mod.rs`, in this case), and then joined it with `name/mod.rs` again, resulting in `name/name/mod.rs`. The first commit adds the regression test and snapshot of current behavior, the second commit fixes it. r? petrochenkov
add crashtests [7/N] Followup to rust-lang#161294. [Link to issue list.](https://github.com/rust-lang/rust/issues?q=is:issue%20state:open%20label:I-ICE%20label:S-has-mcve%20-label:S-bug-has-test%20sort:created-asc%20AND%20(%20140693%20OR%20146210%20OR%20146353%20OR%20149015%20OR%20152204%20OR%20153368%20OR%20154367%20OR%20155482%20OR%20155497%20OR%20157197%20OR%20158243%20OR%20158773%20OR%20158797%20OR%20160329%20OR%20160490%20))
triagebot: Subscribe me to amdgpu changes
…default, r=chenyukang Revert "fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia" This reverts commit 7a44484. This is leading to the issue seen in rust-lang#162272. We're also seeing the same build issues when using a rust toolchain that contains this commit for building fuchsia targets.
rustbot
added
A-compiletest
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 1edd55d (parent) -> eca445e (this PR) Test differencesShow 125 test diffsStage 1
Stage 2
(and 21 additional test diffs) Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard eca445e5ae4a6679cc27d3a09106ce245e13a5a6 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (eca445e): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.6%, secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.6%, secondary -1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 481.679s -> 481.923s (0.05%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 1edd55dcfc In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
run-maketestsuite work with other codegen backend than LLVM #162482 (Makerun-maketestsuite work with other codegen backend than LLVM)dir_pathwhen parsing module from path #162363 (Use correctdir_pathwhen parsing module from path)r? @ghost
Create a similar rollup