Repository navigation
Conversation
rustbot
added
S-waiting-on-author
This comment was marked as resolved.
This comment was marked as resolved.
This will make it possible to remove the compiler's Hash impl for FileName.
Collaborator
|
cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
A subtle consequence of the stage0 redesign is that the compiler must take care to avoid relying on any stdlib-provided Hash impl when computing stable hashes, or at least any such impl that is actually liable to change. This was noticed when trying to strengthen the provided Hash impl for Path, which triggered baffling CI failures because the stable hashes produced by the stage1 compiler (built against stage0 stdlib) were inconsistent with the ones that would have been produced by the stage2 compiler (built against in-tree stdlib). This PR aims to unblock changes to `impl Hash for Path`, by making the compiler not rely on it for stable hashing. It does not attempt to solve the broader problem of the compiler relying on stdlib hash details.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impl Hash for Pathnot use custom intermediate hash cycle #164384A subtle consequence of the stage0 redesign is that the compiler must take care to avoid relying on any stdlib-provided Hash impl when computing stable hashes, or at least any such impl that is actually liable to change.
This was noticed when trying to strengthen the provided Hash impl for Path, which triggered baffling CI failures because the stable hashes produced by the stage1 compiler (built against stage0 stdlib) were inconsistent with the ones that would have been produced by the stage2 compiler (built against in-tree stdlib).
This PR aims to unblock changes to
impl Hash for Path, by making the compiler not rely on it for stable hashing. It does not attempt to solve the broader problem of the compiler relying on stdlib hash details.