Restore linking to itself in implementors section of trait page - #81313
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
camelid
added
A-trait-system
7d74be1 to
1668d3f
Compare
|
cc @sanxiyn, @nodakai, @steveklabnik The reason I think it makes sense to revert is because the change was only made for traits, which makes the documentation look inconsistent - some pages have links to themselves and others don't. I would be okay with a general feature which never adds a link if it goes to the current page, but it would be quite a bit more work and I don't think special-casing traits is the right approach in the meantime. @LeSeulArtichaut the implementation looks fine, but I'd prefer to hear back from one of the three people I pinged before merging this. |
|
I am fine with whatever the rustdoc team feels is appropriate here. |
|
☔ The latest upstream changes (presumably #80987) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Steve said they're OK with whatever we (T-rustdoc) think. So: @rustbot label: -I-needs-decision Is an FCP necessary here? I would think not, but wanted to check. |
1668d3f to
3e65258
Compare
This comment has been minimized.
This comment has been minimized.
3e65258 to
1daddb4
Compare
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
I don't think this needs an FCP, no, this is just fixing an inconsistency rather than adding a feature.
| use_absolute: bool, | ||
| cache: &'a Cache, | ||
| ) -> impl fmt::Display + 'a { | ||
| crate fn print<'a>(&'a self, cache: &'a Cache, use_absolute: bool) -> impl fmt::Display + 'a { |
There was a problem hiding this comment.
Is this ever called with use_absolute: true? If not, can you remove the parameter?
There was a problem hiding this comment.
It's used here:
rust/src/librustdoc/html/render/mod.rs
Line 3773 in 1daddb4
Where AFAICT use_absolute can be true from
rust/src/librustdoc/html/render/mod.rs
Lines 2476 to 2483 in 1daddb4
|
@bors r+ |
|
📌 Commit 1daddb4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
7597: Set remote branch on xtask promote r=matklad a=lnicola to hopefully fix this: ``` $ git switch master Already on 'master' Your branch is up to date with 'upstream/master'. $ git fetch upstream $ git reset --hard upstream/master HEAD is now at 921ec4b Auto merge of rust-lang#81313 - LeSeulArtichaut:revert-32558, r=jyn514 $ git submodule update --recursive Submodule path 'src/tools/rust-analyzer': checked out '1a59f75cdaa730c16a694a4294eccf6dfe6fe0ad' $ git switch -c rust-analyzer-2021-02-08 Switched to a new branch 'rust-analyzer-2021-02-08' $ git fetch origin $ git reset --hard origin/release HEAD is now at 336909b Merge rust-lang#7587 $ git add src/tools/rust-analyzer $ git commit "-m:arrow_up: rust-analyzer" [rust-analyzer-2021-02-08 1774ec1] ⬆️ rust-analyzer 1 file changed, 1 insertion(+), 1 deletion(-) $ git push fatal: The current branch rust-analyzer-2021-02-08 has no upstream branch. To push the current branch and set the remote as upstream, use git push --set-upstream origin rust-analyzer-2021-02-08 Error: command `git push` failed, exit code: 128 ``` Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
8 participants
Reverts #32558 as proposed in this Zulip discussion
r? @jyn514 cc @camelid