fix "all x does is call x" - #2975
Open
tshepang wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
Member
Author
|
r? jyn514 |
jyn514
reviewed
Aug 18, 2026
|
|
||
| There is a binary that wraps bootstrap called `x`. | ||
| All it does is run `./x`, but it can be installed system-wide and run from any subdirectory of a checkout. | ||
| It runs `./x.py`, and can be installed system-wide and run from any subdirectory of a checkout. |
Member
There was a problem hiding this comment.
hm, this was intentional to change. x.py itself is not very interesting, and the x wrapper tries to call the shell scripts before the python script if it can. If you want to make this more clear, maybe say "all it does is run bootstrap"?
Member
Author
There was a problem hiding this comment.
oh, missed that ./x is not same thing as x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was lost in #2966