Skip to content

Update the triage comment with results when a benchmark run completes - #2545

Merged
JonathanBrouwer merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:triage-run-update
Aug 24, 2026
Merged

Update the triage comment with results when a benchmark run completes#2545
JonathanBrouwer merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:triage-run-update

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Aug 22, 2026

Copy link
Copy Markdown
Member

Blocked on #2543

Recommend reviewing commit by commit.

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be super cool :)

Comment thread site/src/github/comparison_summary.rs Outdated
Comment thread site/src/github/triage.rs
Comment thread site/src/github/comparison_summary.rs
@JonathanBrouwer
JonathanBrouwer marked this pull request as ready for review August 22, 2026 12:34

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, impl looks good, let's try it on prod!

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

^ Added the Recover on update_comment_content failure commit

@JonathanBrouwer
JonathanBrouwer added this pull request to the merge queue Aug 24, 2026
Merged via the queue into rust-lang:main with commit 1c8f187 Aug 24, 2026
15 checks passed
@JonathanBrouwer
JonathanBrouwer deleted the triage-run-update branch August 24, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants