Add a new environment variable for adding a custom libgccjit path - #957
Open
techmetx11 wants to merge 1 commit into
Open
Add a new environment variable for adding a custom libgccjit path#957techmetx11 wants to merge 1 commit into
techmetx11 wants to merge 1 commit into
Conversation
antoyo
reviewed
Aug 20, 2026
| paths.push(llvm_target_path); | ||
| } | ||
| if let Ok(custom_path) = env::var("CG_GCCJIT_SEARCH_PATH").as_deref() { | ||
| paths.push(PathBuf::from(custom_path).join("libgccjit.so")); |
Contributor
There was a problem hiding this comment.
Since this is added last, this means that if a library is found in the sysroot, the library from the env var won't be used.
I believe it would make more sense to use the one from the env var if it is exists.
Doing that means we can probably move that check outside this function.
| paths.push(llvm_target_path); | ||
| } | ||
| if let Ok(custom_path) = env::var("CG_GCCJIT_SEARCH_PATH").as_deref() { | ||
| paths.push(PathBuf::from(custom_path).join("libgccjit.so")); |
Contributor
There was a problem hiding this comment.
Do you think it would be better to have the env var point directly at the library file?
Doing so, we could support libraries named libgccjit.so.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a environment variable, that lets the user choose where should the driver look for
libgccjitin.This is better (in my opinion) than making a symlink in the Rust toolchain directory, because you don't have to assume which toolchain and host CPU architecture the user is using