Conversation
bluss
force-pushed
the
msrv
branch
5 times, most recently
from
August 1, 2024 17:41
14c8123 to
9d532bc
Compare
Fix the min_value() / max_value() lints. Also remove clippy::many_single_char_names, clippy::unreadable_literal from the allow list since they are not needed anymore.
bluss
changed the title
bluss
enabled auto-merge
August 1, 2024 17:55
bluss
changed the title
bluss
added this pull request to the merge queue
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Prepare for 0.16. Using Rust 1.64 as MSRV is still quite careful I think.
PyO3 is 1.63, which inspires us to push towards old versions. But we need the workspace = true feature for sane organization, which is Rust 1.64.