feat(net): upgrade to spec 1.4 - #40
Open
mkroening wants to merge 2 commits into
Open
Conversation
This is more useful since one is always a superset of the other. This way, we can avoid having two separate structs. This is also how other implementation usually model these conditional fields.
mkroening
force-pushed
the
virtio-net-hdr
branch
from
August 21, 2026 12:39
b417d0c to
d8d4aa6
Compare
Member
Author
|
@phip1611, now with (a bit) better commit messages for a start. :) |
phip1611
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the spec diff: https://docs.oasis-open.org/virtio/virtio/v1.4/cs01/virtio-v1.4-cs01-diff-from-v1.2-cs01.html#x1-2700001
This also reworks the
virtio::net::Hdrsupersets to be easily composable.