Repository navigation
Fix wasm_js feature combined with a backend override on Wasm - #875
Open
ryanhossain9797 wants to merge 3 commits into
Open
ryanhossain9797 wants to merge 3 commits into
ryanhossain9797 wants to merge 3 commits into
Conversation
`Error::WEB_CRYPTO` is only defined when the `wasm_js` backend is actually selected, but its description in `Error::internal_desc` was gated on the `wasm_js` feature alone. Enabling the feature together with `getrandom_backend="unsupported"`, `"custom"` or `"extern_impl"` on `wasm32-unknown-unknown` therefore failed to compile. Exclude those overrides from the cfg and extend the CI job to build the `unsupported` and `custom` overrides with and without `wasm_js`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
josephlr
approved these changes
Nov 4, 2026
josephlr
left a comment
josephlr
left a comment
Member
There was a problem hiding this comment.
Good catch! And the CI fix also looks good.
Open
Author
Thanks! What's the merge process? Do you guys handle it? |
Member
#872 will track the next release (and if/how we include this PR). |
Member
|
Hm, I wonder if we have a similar issue with |
Member
|
I opened #876 as a potential alternative to this. |
newpavlov
added a commit
that referenced
this pull request
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::WEB_CRYPTOis only defined when thewasm_jsbackend is actually selected, but its description inError::internal_descwas gated on thewasm_jsfeature alone. Enabling the feature together withgetrandom_backend="unsupported","custom"or"extern_impl"onwasm32-unknown-unknowntherefore failed to compile.Exclude those overrides from the cfg and extend the CI job to build the
unsupportedandcustomoverrides with and withoutwasm_js.