Skip to content

v0.8: fix no-std + serde1 build #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhardy wants to merge 2 commits into
base: 0.8
Choose a base branch
from
+12 −6
Open

v0.8: fix no-std + serde1 build #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad885e
Add test + fix for feature serde1 without std
dhardy Aug 18, 2026
9fd5638
Prepare 0.8.8
dhardy Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
cargo test --target ${{ matrix.target }} --all-features
cargo test --target ${{ matrix.target }} --benches --features=nightly
cargo test --target ${{ matrix.target }} --manifest-path rand_distr/Cargo.toml --benches
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features min_const_gen
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features min_const_gen,serde1
- name: Use Cargo.lock.msrv (1.36)
if: ${{ matrix.toolchain == '1.36.0' }}
run: |
Expand All @@ -86,7 +86,7 @@ jobs:
run: |
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features
cargo build --target ${{ matrix.target }} --no-default-features --features alloc,getrandom,small_rng
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features=alloc,getrandom,small_rng
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features=alloc,getrandom,small_rng,serde1
cargo test --target ${{ matrix.target }} --examples
- name: Test rand (all stable features, non-MSRV)
if: ${{ matrix.toolchain != '1.36.0' }}
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ A [separate changelog is kept for rand_core](rand_core/CHANGELOG.md).

You may also find the [Upgrade Guide](https://rust-random.github.io/book/update.html) useful.

## [0.8.8] - 2026-08-19
### Fixes
- Fix build for `--no-default-features --features serde1` ([#1825])

[#1825]: https://github.com/rust-random/rand/pull/1825

## [0.8.7] - 2026-07-02
### Fixes
- Fix possible memory safety violation due to deserialization of `UniformChar` from bad source ([#1804])
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock.msrv
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "rand"
version = "0.8.7"
version = "0.8.8"
authors = ["The Rand Project Developers", "The Rust Project Developers"]
license = "MIT OR Apache-2.0"
readme = "README.md"
Expand Down
2 changes: 1 addition & 1 deletion src/distributions/uniform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ where
D: serde::Deserializer<'de>,
{
let sampler = <UniformInt<u32> as serde::Deserialize>::deserialize(d)?;
if sampler.max() > std::char::MAX as u32 - CHAR_SURROGATE_LEN {
if sampler.max() > core::char::MAX as u32 - CHAR_SURROGATE_LEN {
return Err(serde::de::Error::custom(
"bad sampler range for UniformChar",
));
Expand Down
Loading