Repository navigation
fix(helm): qualify default operator image repositories - #276
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1513844ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| image: | ||
| repository: rustfs/operator | ||
| repository: docker.io/rustfs/operator |
There was a problem hiding this comment.
Update the documented operator image default
When users consult the bundled chart README to audit or configure this new default, deploy/rustfs-operator/README.md:124 still lists rustfs/operator. The table was accurate before this line changed, but now it contradicts the rendered chart and still presents the short name this fix is intended to remove, giving restricted-registry users the wrong documented default.
Useful? React with 👍 / 👎.
Type of Change
Related Issues
Fixes #272
Summary of Changes
Use
docker.io/rustfs/operatoras the default image repository for the Operator, Console, and COSI driver. This makes the registry explicit for environments that restrict short image names and removes ambiguity from registry search rules. Existing Helm values overrides remain supported.Remove three redundant closure borrows in workload security validation to satisfy Clippy on the current stable toolchain. Set an explicit default namespace in STS Helm rendering tests so runner namespace configuration does not affect their assertions; test-specific namespace overrides remain supported.
Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Verified that all three default image references include
docker.ioand that each repository override is rendered unchanged.Additional Notes
Reproduced the STS rendering failure with
HELM_NAMESPACE=sm-standard-2before the fix and verified all five STS manifest tests pass afterward. GitHub Test and Lint passed: https://github.com/rustfs/operator/actions/runs/38384291607. Docker Build was skipped by the workflow.Users retaining old repository values, including through
--reuse-values, must explicitly update those values to adopt the new defaults.