Skip to content

fix(helm): qualify default operator image repositories - #276

Merged
GatewayJ merged 3 commits into
rustfs:mainfrom
GatewayJ:fix/helm-image-registry
Oct 13, 2026
Merged

GatewayJ merged 3 commits into
rustfs:mainfrom
GatewayJ:fix/helm-image-registry

Conversation

@GatewayJ

@GatewayJ GatewayJ commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

Fixes #272

Summary of Changes

Use docker.io/rustfs/operator as the default image repository for the Operator, Console, and COSI driver. This makes the registry explicit for environments that restrict short image names and removes ambiguity from registry search rules. Existing Helm values overrides remain supported.

Remove three redundant closure borrows in workload security validation to satisfy Clippy on the current stable toolchain. Set an explicit default namespace in STS Helm rendering tests so runner namespace configuration does not affect their assertions; test-specific namespace overrides remain supported.

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit (fmt-check + clippy + test + console-lint + console-fmt-check)
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CHANGELOG.md updated under [Unreleased] (if user-visible change)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (CRD/API compatibility)
  • Requires doc/config/deployment update
  • Other impact: Adopting the new image references triggers Deployment updates. Console uses Recreate and process-local sessions, so expect a brief interruption and sign in again after restart.

Verification

HELM_NAMESPACE=sm-standard-2 make -j8 pre-commit
helm lint deploy/rustfs-operator
helm template registry-check deploy/rustfs-operator --set cosiDriver.enabled=true
helm template registry-check deploy/rustfs-operator --set cosiDriver.enabled=true \
  --set operator.image.repository=harbor.example.com/team/operator \
  --set console.image.repository=harbor.example.com/team/console \
  --set cosiDriver.image.repository=harbor.example.com/team/cosi

Verified that all three default image references include docker.io and that each repository override is rendered unchanged.

Additional Notes

Reproduced the STS rendering failure with HELM_NAMESPACE=sm-standard-2 before the fix and verified all five STS manifest tests pass afterward. GitHub Test and Lint passed: https://github.com/rustfs/operator/actions/runs/38384291607. Docker Build was skipped by the workflow.
Users retaining old repository values, including through --reuse-values, must explicitly update those values to adopt the new defaults.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T09:05:49.560221Z e151384 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1513844ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


image:
repository: rustfs/operator
repository: docker.io/rustfs/operator

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the documented operator image default

When users consult the bundled chart README to audit or configure this new default, deploy/rustfs-operator/README.md:124 still lists rustfs/operator. The table was accurate before this line changed, but now it contradicts the rendered chart and still presents the short name this fix is intended to remove, giving restricted-registry users the wrong documented default.

Useful? React with 👍 / 👎.

@GatewayJ
GatewayJ added this pull request to the merge queue Oct 13, 2026
Merged via the queue into rustfs:main with commit 2664fc7 Oct 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Use fully qualified names for operator image in helm chart

1 participant