Repository navigation
Conversation
Read the erasure layout through an injected future so the reconcile can run against a mocked API server, and document removing user-created budgets before upgrading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Closes #289
Summary of Changes
The operator now manages one PodDisruptionBudget per Tenant pool, so node drains and autoscaler scale-downs cannot evict more pool Pods than the pool's erasure sets can lose while keeping write quorum.
pod_disruption_budgetreconcile step after the pool StatefulSets. The budget is named<tenant>-<pool>, owned by the Tenant, carries the pool labels and selects the pool Pods.minAvailable= servers minus the servers that can be down while every erasure set keeps write quorum. It is derived from the layout RustFS reports in/rustfs/admin/v3/info(drivepool_index,set_index, endpoint host) and the standard parity, capped at the default parity for the set size, the same way RustFS computes write quorum.ok. If the layout cannot be read, existing budgets stay as they are and the step retries in 60s.spec.disablePodDisruptionBudget(default: budgets on). Setting it deletes only the budgets owned by the Tenant; budgets of removed pools are deleted as well.rustfs-admin:RustfsServerInfonow deserializesservers[].drives[].deploy/k8s-dev):policy/poddisruptionbudgetsget, list, watch, create, patch, delete. The controller watches owned budgets.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
The CRD gains an optional field and the operator ClusterRole gains PodDisruptionBudget permissions, so the chart (CRD and RBAC) must be upgraded together with the operator image. Existing Tenants get budgets on the next reconcile unless they set
spec.disablePodDisruptionBudget: true.Verification
make pre-commit cargo test --lib pod_disruption_budgetAdditional Notes