Show the description next to the window list shortcut recorder - #1832
Open
MyronKoch wants to merge 1 commit into
Open
Show the description next to the window list shortcut recorder#1832MyronKoch wants to merge 1 commit into
MyronKoch wants to merge 1 commit into
Conversation
The row carried two leading constraints: one pinning the row itself to the shortcut column, from when it sat indented under the checkboxes, and one pinning the recorder to that same column so it would line up with the rows above. Together they left the label between them with no width at all, so it rendered as nothing and the recorder looked unlabelled. Removing the row pin lets the label take its natural width while the recorder stays in the column. The text is also shortened, since the column is only as wide as the longest grid label and the previous wording matched it exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the missing description you mentioned on #1808 - good catch, and it was worse than it looked.
The row had two leading constraints fighting each other. One pinned the row itself to the shortcut column, left over from when it sat indented under the checkboxes; the other pinned the recorder to that same column so it would line up with the shortcut rows above. Since the row started where the recorder had to start, the label between them was left with no width at all - so it rendered as nothing, and no wording would have helped.
Removing the row pin lets the label size itself while the recorder stays in the column. I also shortened the text to "Toggle window list": the column is only as wide as the longest grid label, and the previous wording matched it almost exactly, which left no margin.
That same stray pin is why the recorder was out of line with the other shortcut rows in the first place, so this fixes both halves of it.
No behaviour change beyond the settings row. Full suite passes.