Skip to content

fix: escape untrusted TLS diagnostic text - #943

Merged
ryanfowler merged 1 commit into
mainfrom
fix/tls-terminal-safe-diagnostics
Aug 7, 2026
Merged

fix: escape untrusted TLS diagnostic text#943
ryanfowler merged 1 commit into
mainfrom
fix/tls-terminal-safe-diagnostics

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • escape terminal controls and bidi controls in remote TLS diagnostic text
  • sanitize certificate display names, DNS SANs, and negotiated ALPN output through one renderer helper
  • test malicious CN, SAN, and ALPN values

Checks

  • cargo fmt --check
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --locked --all-features --lib --bins
  • cargo test --locked --all-features tls::inspect::tests

@ryanfowler
ryanfowler enabled auto-merge August 7, 2026 13:29
@ryanfowler
ryanfowler merged commit 65f4255 into main Aug 7, 2026
7 of 8 checks passed
@ryanfowler
ryanfowler deleted the fix/tls-terminal-safe-diagnostics branch August 7, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant