fix(cancel): route projects through project-capable AppleScript - #125
Merged
Conversation
things cancel <project> resolved the reference then unconditionally called CancelTask, whose AppleScript addresses 'to do id' — which cannot name a project — so it failed with a raw osascript error. Add CancelProject and mirror CompleteCmd's project branch, including the interactive confirmation before cascading the cancellation. Ride-alongs from the same review pass: - document the numeric-index reference form in show/complete/cancel help (resolveTask has always accepted it; only edit's help said so) - add -a short flag to 'things projects --area' for consistency with list/open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the v0.5.1 scout findings.
things cancel <project>resolved the reference then unconditionally calledCancelTask, whose AppleScript addressesto do id "<uuid>"— which cannot name a project — so cancelling a project died with a raw osascript error.completehas had the proper project branch (viaproject id) all along;cancelnever got one.things.CancelProject, mirroringCompleteProjectCancelCmdnow branches onmodel.TypeProjectwith the same interactive confirmationcompleteuses (cancelling cascades to the project's tasks)Ride-alongs:
show/complete/cancelhelp now documents the numeric-index reference form (resolveTaskhas always accepted it; onlyeditsaid so)things projectsgains the-ashort flag for--area, matchinglist/open