Repository navigation
compiler: share artifacts across build directories - #524
Merged
Merged
Conversation
The shared cache identity named each protobuf binding root by its key path. A root outside every module of the graph keys by its path from the request directory, so the same program built from two directories at different depths, as bldr does for its js and web/js/wasm platforms, shared no artifact: every key differed. The identity no longer names binding roots. They change output only through the bindings a package reads, which protobufSideInputs already keys per package. The replaced checkout test now builds its second checkout two levels deeper with a binding root outside the graph. Signed-off-by: Christian Stewart <christian@aperture.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared cache identity named each protobuf binding root by its key path. A root outside every module of the graph keys by its path from the request directory, so the same program built from two directories at different depths, as bldr does for its js and web/js/wasm platforms, shared no artifact. In a cold Spacewave release build each plugin's second platform compile replayed none of its packages; the cache's program manifests share 0 of 861 artifact keys between the two platforms of one plugin.
The identity no longer names binding roots. They change output only through the bindings a package reads, which protobufSideInputs already keys per package. The replaced checkout test now builds its second checkout two levels deeper with a binding root outside the graph.