Repository navigation
feat(strings): add CutLast - #525
Merged
Merged
Conversation
Go 1.27 adds strings.CutLast, which the strings override did not provide: its parity ledger classified it as blocked, so any program that referenced it failed to compile with parity-blocked-use. This includes programs that only take its value, such as interpreter symbol tables generated for Go 1.27. Implement CutLast like Cut, cutting at the last instance of sep, and classify it as real since go1.27 so the ledger stays valid on older toolchains. Add unit tests and a compliance test whose output matches native Go. Signed-off-by: Randall C. O'Reilly <oreilly@ucdavis.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.27 adds strings.CutLast, which the strings override did not provide. Its parity ledger classified it as blocked, so any program that references it fails to compile with parity-blocked-use. That includes programs that only take its value, such as interpreter symbol tables generated for Go 1.27: the Cogent Core docs site, which embeds yaegi symbols for the standard library, stopped building after its symbols were regenerated for Go 1.27.
This implements CutLast like Cut, cutting at the last instance of sep, and classifies it as real since go1.27 so the ledger stays valid on older toolchains. It adds unit tests and a compliance test (strings_cutlast) whose output matches native Go.