Repository navigation
Conversation
An assignment to a slice element, including a compound one such as s[i] += v, writes through sliceElems and sliceSlot, which, like the helpers of the previous commit, tried a long chain of representations. Give them the same small fast path for a window object, a typed slice or a plain array, with the existing code in slow functions. A read-modify- write of a tensor element (Cogent Lab, s.Values[s.Index3To1D(i, j, k)] += v) takes 29 ns instead of 34 ns under Node 26. Signed-off-by: Randall C. O'Reilly <oreilly@ucdavis.edu>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second commit of #531, which was not included when #531 merged.
An assignment to a slice element, including a compound one such as s[i] += v, writes through sliceElems and sliceSlot. Like the helpers #531 split, they tried a long chain of representations on every call, so engines did not inline them.
This gives them the same small fast path for a window object, a typed slice or a plain array, with the existing code moved unchanged into slow functions. In the tensor benchmark from #531, a read-modify-write of a tensor element (Cogent Lab, s.Values[s.Index3To1D(i, j, k)] += v) takes 29 ns instead of 34 ns under Node 26.
The full Go test suite, typecheck and the builtin vitest suite pass.