Fix race condition where response recording can run before request recording under concurrent workers#10
Open
lloricode wants to merge 3 commits into
Open
Conversation
Update constructor parameter type hint for data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition in the queued recorder where the response
recording can be processed before the request recording under
concurrent queue workers, causing:
Root cause
When
barstool.queue.enabled = true, request and response recordingsare dispatched as independent jobs sharing the same
uuid. Withmultiple workers (e.g. Horizon), there is no guaranteed ordering
between the two — the response job can be picked up first.
Previously, the response path used
updateOrCreate()(or equivalent),so when it ran first, it would insert a new row containing only
response-side fields, omitting
connector_class,request_class,method,request_headers,request_body. MySQL then rejected theinsert because those columns have no default.
Evidence from production
Sentry captured this INSERT statement generated by the response job
running first: