Use default values for properties missing from --settings file#125
Merged
Conversation
sameer
reviewed
Jul 9, 2026
AmadeusW
commented
Jul 15, 2026
|
|
||
| /// A cross-platform type used to store all configuration types. | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "serde", serde(default))] |
Contributor
Author
There was a problem hiding this comment.
Without this default, we'd need to create settings with empty objects, e.g. { "conversion": {} }
AmadeusW
commented
Jul 15, 2026
| /// Dots per inch for pixels, picas, points, etc. | ||
| pub dpi: f64, | ||
| /// Set the origin point in millimeters for this conversion | ||
| #[cfg_attr(feature = "serde", serde(default = "zero_origin"))] |
Contributor
Author
There was a problem hiding this comment.
This is OK to remove because impl Default for ConversionConfig { on line 56 provides the zero_origin default. At the same time, this might be less obvious, so let me know what you think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use default values for properties missing from --settings file.
This allows for a minimal settings file, such as