Repository navigation
Conversation
…enter condensed line layout - Extract notification settings into a dedicated sub-page (`IslandNotificationSettingsUI`) and register `ISLAND_NOTIFICATIONS_FEATURE_ID`, replacing `IslandNotificationOptionsBottomSheet`. - Balance condensed line layout on both sides of the camera slot in `LineTemplate` and `IslandRoot`. - Update string resources and add unit tests in `CondensedLineTest` for centered camera positioning.
…act_line_peek # Conflicts: # app/src/main/java/com/sameerasw/essentials/island/model/IslandModels.kt # app/src/main/java/com/sameerasw/essentials/ui/features/display/IslandSettingsUI.kt
Contributor
Author
|
noticed that this is into main, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for a bug that the island was showing even with DND ON.
Added on notification sections the ability to show the island popup following the DND mode or not.
current PR is dependant of #1303, so merging that first wouldn't break this PR
Type of change
UI changes
Screen_recording_20261011_220423.mp4
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).