Skip to content

feat(island): handle DND and show island even with DND mode ON - #1349

Merged
sameerasw merged 2 commits into
sameerasw:developfrom
isaacsa51:feat/island/respect_dnd_mode
Oct 13, 2026
Merged

sameerasw merged 2 commits into
sameerasw:developfrom
isaacsa51:feat/island/respect_dnd_mode

Conversation

@isaacsa51

@isaacsa51 isaacsa51 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fix for a bug that the island was showing even with DND ON.

Added on notification sections the ability to show the island popup following the DND mode or not.

current PR is dependant of #1303, so merging this first would break this PR

Type of change

  • Bug fix
  • New feature
  • UI / visual update
  • Performance improvement
  • Refactoring / cleanup
  • Translations
  • Build / CI tooling

UI changes

Screen_recording_20261011_220423.mp4

Checklist

Before submitting, please make sure:

  • The base branch is set to develop (not main).
  • The app builds cleanly locally with ./gradlew assembleDebug.
  • Unit tests pass with ./gradlew testDebugUnitTest.
  • You tested the changes on a device or emulator (including Shizuku or Root if applicable).
  • New preferences use SettingsRepository for keys and getter/setter methods.
  • New user-facing settings are registered in FeatureRegistry.kt for search indexing.
  • New UI follows the design system in ui/core/ (RoundedCardContainer, IconToggleItem, etc.).
  • Strings are added to res/values/strings.xml and drawables use rounded variants (R.drawable.rounded_*).

@isaacsa51
isaacsa51 marked this pull request as ready for review October 12, 2026 05:57
@isaacsa51
isaacsa51 requested a review from sameerasw as a code owner October 12, 2026 05:57
@sameerasw
sameerasw force-pushed the feat/island/respect_dnd_mode branch from 4b1421f to 8c71924 Compare October 13, 2026 06:27

@sameerasw sameerasw left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions <3

@sameerasw
sameerasw merged commit a55d15e into sameerasw:develop Oct 13, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Essentials Progress Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants