Skip to content

chore(diy): added value label for automation row - #1352

Merged
sameerasw merged 2 commits into
sameerasw:developfrom
isaacsa51:feat/diy/automation_row_value_label
Oct 13, 2026
Merged

sameerasw merged 2 commits into
sameerasw:developfrom
isaacsa51:feat/diy/automation_row_value_label

Conversation

@isaacsa51

@isaacsa51 isaacsa51 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Small feature that for me seems to be functional to see each automation value.

Now the AutomationItem renders (if any) the value selected from the automation created, generated strings for the All day, Calendar and All calendar string.

Generated the preview, this helps us see how the composable looks without compiling.

Type of change

  • Bug fix
  • New feature
  • UI / visual update
  • Performance improvement
  • Refactoring / cleanup
  • Translations
  • Build / CI tooling

UI changes

Mostly all values that can hold a value are on the image:
Screenshot 2026-10-12 at 4 41 18 a m

Checklist

Before submitting, please make sure:

  • The base branch is set to develop (not main).
  • The app builds cleanly locally with ./gradlew assembleDebug.
  • Unit tests pass with ./gradlew testDebugUnitTest.
  • You tested the changes on a device or emulator (including Shizuku or Root if applicable).
  • New preferences use SettingsRepository for keys and getter/setter methods.
  • New user-facing settings are registered in FeatureRegistry.kt for search indexing.
  • New UI follows the design system in ui/core/ (RoundedCardContainer, IconToggleItem, etc.).
  • Strings are added to res/values/strings.xml and drawables use rounded variants (R.drawable.rounded_*).

@isaacsa51
isaacsa51 requested a review from sameerasw as a code owner October 12, 2026 10:42
@sameerasw
sameerasw force-pushed the feat/diy/automation_row_value_label branch from 48c8eb0 to 43518bb Compare October 13, 2026 06:37

@sameerasw sameerasw left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions <3

@sameerasw
sameerasw merged commit 8bf9409 into sameerasw:develop Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants