Conversation
htsFile format detection allows files to be opened that use compression types that are not supported by some other interfaces, notably hts_getline(). If such a file is passed to hts_getline(), it's more polite to print a message and return an error code rather than call abort(). The abort() for unsupported delimiters in the same function is left, as this is most likely to be a coding error. Signed-off-by: Rob Davies <rmd+git@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
htsFile format detection allows files to be opened that use compression types that are not supported by some other interfaces, notably
hts_getline(). If such a file is passed tohts_getline(), it's more polite to print a message and return an error code rather than callabort().The
abort()for unsupported delimiters in the same function is left, as this is most likely to be a coding error.Fixes #2091