Skip to content

fix(bundle): task_images lists every image, however it's stored - #408

Merged
earakely-scale merged 1 commit into
mainfrom
fix/task-images-lists-every-image
Oct 30, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
fix/task-images-lists-every-image

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

What

task_images refused a task with an image stored only as a tarball under a bare name, raising "stored only as a docker save tarball". It ran the import's walk with no refs, and without one the import can't write that image. But that image is exactly what an export loads on its VM, pushes, and then hands back as a ref. So the listing was refusing the images it exists to find.

The listing now names every image without judging how it's stored. It still raises on the import's other problems, such as an env the store doesn't hold. The previous test asserted the wrong behaviour and is replaced:

  • New: a tarball-only image is listed, and the import then accepts a ref for it.
  • Refusal: the listing still refuses a task whose env isn't in the store.

Testing

tst/unit/bundle passes (1134), and lint is clean.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

task_images now lists images regardless of how they are stored, so callers can push them and supply references to import_task.

  • Task image listings include tarball-only images for later registry imports.

Reviews (1) · Last reviewed commit: "fix(bundle): task_images lists every ima..." · Reviewed by Greptile

task_images ran the import's walk with no refs, so an image the import can write only as a
given reference, such as a tarball under a bare name, was refused as unwritable and the listing
raised. Those are exactly the images an export loads and pushes, then names by reference. The
listing now names every image without judging how it's stored; it still raises on the import's
other problems.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner October 30, 2026 17:00
@earakely-scale
earakely-scale merged commit 58826b4 into main Oct 30, 2026
41 of 43 checks passed
@earakely-scale
earakely-scale deleted the fix/task-images-lists-every-image branch October 30, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant