[earakely-scale]

recording_chaos_test.py::test_a_restarted_driver_forgets_its_recording_and_keeps_the_segments_it_closed fails now and then in integration-local-slow: after docker restart -t 2 the driver answers again within a second, but computer-ready says not ready for the whole 60 s wait.

Why

docker restart keeps the container's filesystem. When the stop outlasts its grace period, X is killed before it can remove /tmp/.X99-lock. On the next boot pids are handed out again from 1, so the pid in that lock is often taken, by X itself or by another program. X then takes the lock for a server still running and exits with Server is already active for display 99. supervisord retries three times. When the pid belongs to a process that stays up, every retry fails and xvfb ends FATAL. The driver keeps serving, so the readiness checks fail forever.

Reproduced on the base image and on a composed desktop: a hard restart left xvfb FATAL with the reference driver RUNNING.

Change

• start-desktop xvfb removes the lock before starting X. supervisord runs one X at a time, so any lock there is stale.
• A new base test plants a lock naming pid 1 (tini), hard-restarts, and expects every program RUNNING. It fails on main and passes here.
• _ready's timeout now names the checks that failed, so a computer that never comes up says why.

🤖 Generated with Claude Code

Confidence Score: 4/5

The fix appears safe to merge, with a non-blocking gap in the new regression test.

Findings

1.  Failed startup passes the test ▶

Fix with agent prompt

### Issue 1
tst/integration/computer/base_computer_test.py:98-101
The new test passes if `_all_running(name)` returns an empty string after the restart. That helper returns the last command's output even when every attempt fails, and `all(...)` over empty output is true. Assert that `running` is nonempty before checking its lines so a desktop that never starts cannot pass this regression test.

```suggestion
    assert running and all(" RUNNING " in line for line in running.splitlines()), running

@pytest.mark.parametrize("setting, value, error", [
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Removes the leftover X lock before Xvfb starts after a hard restart.

• The Ubuntu desktop clears X’s stale lock before it starts the display.
• Recording restart timeouts say which readiness checks failed.

_{Reviews (1) · Last reviewed commit: "fix(computers): a restarted desktop clea..." · Reviewed by Greptile}

[greptile-apps]

Failed startup passes the test

The new test passes if _all_running(name) returns an empty string after the restart. That helper returns the last command's output even when every attempt fails, and all(...) over empty output is true. Assert that running is nonempty before checking its lines so a desktop that never starts cannot pass this regression test.

Suggested change

	assert all(" RUNNING " in line for line in running.splitlines()), running
	@pytest.mark.parametrize("setting, value, error", [
	assert running and all(" RUNNING " in line for line in running.splitlines()), running
	@pytest.mark.parametrize("setting, value, error", [

Prompt To Fix With AI

This is a comment left during a code review.
Path: tst/integration/computer/base_computer_test.py
Line: 98-101

Comment:
**Failed startup passes the test**

The new test passes if `_all_running(name)` returns an empty string after the restart. That helper returns the last command's output even when every attempt fails, and `all(...)` over empty output is true. Assert that `running` is nonempty before checking its lines so a desktop that never starts cannot pass this regression test.

```suggestion
    assert running and all(" RUNNING " in line for line in running.splitlines()), running

@pytest.mark.parametrize("setting, value, error", [
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.