Repository navigation
fix(artifacts): a digest ref its registry refuses without credentials is kept, for Docker's own login to pull - #412
Open
earakely-scale wants to merge 1 commit into
Conversation
… is kept, for Docker's own login to pull A bundle whose images are in a private registry couldn't run with core's default stores: put_ref checked each digest-pinned ref against a registry the local store holds no credentials for, which answered 401, though Docker on the machine was logged in to it. Such a ref is now recorded as given; a tag still has to be resolved, and a refusal of the store's own credentials still fails. The README bundle init writes says a digest-pinned image needs only docker login. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bundle whose images are in a private registry couldn't run on a recipient's machine with core's default stores, even with Docker logged in to that registry. Writing each image,
put_refchecks its ref against the registry, and core reaches a private registry only with the image store's credentials. The local store holds none for it, so the registry answers 401 and the run stops. An ECR image store can read it, but then a run doesn't set up the gateway and service-db envs, which it does only in local stores.Change
put_refrecords a ref already pinned to a digest as given when its registry refuses to serve it to a store holding no credentials for it. The sandbox's Docker then pulls it with its own login. A tag still has to be resolved, and a refusal of the store's own credentials still fails.bundle initwrites says a digest-pinned image needs onlydocker loginto its registry.Verified
I exported a bundle from a dev task: two MCP servers whose images are in a private ECR, a universe, an agent, and a rubrics judge. I ran it with this branch installed alongside PyPI dependencies only, core's local stores, and Docker logged in to the registry. It passed 5/5 steps. On 0.9.1394 the same run stops writing its first env, with HTTP 401.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Allows
DockerImageArtifact.put_refto keep a digest-pinned reference after an anonymous registry refusal.Reviews (1) · Last reviewed commit: "fix(artifacts): a digest ref its registr..." · Reviewed by Greptile