Skip to content

feat(website): a session cookie per site, /go?sid=, the clock's rate, conformance levels and models= (FD-4683) - #444

Open
williamloo-scale wants to merge 4 commits into
wloo/website-gateway-authfrom
wloo/website-sdk-followups
Open

williamloo-scale wants to merge 4 commits into
wloo/website-gateway-authfrom
wloo/website-sdk-followups

Conversation

@williamloo-scale

@williamloo-scale williamloo-scale commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #443.

Website SDK follow-ups.

  • Session cookie per site. agentenv_session_<name>, named on the card, so two sites under one gateway host don't overwrite each other's. The shared agentenv_session is still read for one release.
  • /go?sid=. Each sid is a store of its own started from the seed, the CUA-Gym convention the website state verifier reads. A request runs in its ?sid=, else the one its browser last named (<cookie>_sid), else the default session, which is the data plane's state as before.
  • Clock rate. /clock/time also answers virtual_seconds_per_real_second, which UniverseClock follows instead of inferring it.
  • Conformance: required vs recommended. Only what website/v1 requires of any server fails a run: any host, health, no page at the reserved paths (new), the data-plane round trip. The card's details, X-Universe-Now, clock, forwarded headers and cookies warn; --strict fails on a warning.
  • @website(models=...). An object with load/export/reset, or SQLAlchemy models. With models the site gets self.db on DATABASE_URL, and the data plane and /go read those tables, so the GUI and the MCP tools share rows.

Before merging

models= adds an optional db extra (sqlalchemy>=2.0), included in dev, and updates uv.lock. SQLAlchemy is imported only when a site uses models.

Test

Unit suite: 12,625 passed; the models= tests (6) also pass with SQLAlchemy installed.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 4/5

Fix enum restores before merging; the conformance check can otherwise leave populated tables empty.

Fix All in CursorFindings

  1. P1 Enum rows fail to restore ▶
Fix with agent prompt
### Issue 1
packages/agentenv-protocol/src/agentenv_protocol/website/database.py:176-180
`Tables.export()` turns Python enum members into their values, but `_row()` does not turn them back into members. SQLAlchemy's `Enum(State)` stores member names by default. For a member such as `OPEN = "open"`, the export contains `"open"` while PostgreSQL expects `"OPEN"`.

Restoring that export fails. The conformance check calls `data/reset` first, so it can leave the site's tables empty. Convert exported enum values back to the column's enum members before inserting.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds per-site login cookies, an explicit clock rate, required versus recommended conformance checks, and database-backed websites through models=.

  • Website pages and tools can share rows in the environment database.
  • Each named website uses its own browser session cookie.
  • The conformance command separates required website checks from optional recommendations.
  • Website clocks follow the rate reported by the gateway clock.

Reviews (13) · Last reviewed commit: "refactor(website): no /go?sid= sessions ..." · Reviewed by Greptile

@williamloo-scale williamloo-scale changed the title website: per-site session cookie, /go?sid=, clock rate, conformance levels, models= (FD-4683) feat(website): a session cookie per site, /go?sid=, the clock's rate, conformance levels and models= (FD-4683) Nov 3, 2026
@williamloo-scale
williamloo-scale marked this pull request as ready for review November 3, 2026 00:24
@williamloo-scale
williamloo-scale requested a review from a team as a code owner November 3, 2026 00:24
@socket-security

socket-security Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​psycopg@​3.3.710010010010070

View full report

@williamloo-scale
williamloo-scale force-pushed the wloo/website-gateway-auth branch from 8dcebd1 to 4c1fcc1 Compare November 3, 2026 21:50
@williamloo-scale
williamloo-scale force-pushed the wloo/website-sdk-followups branch from 8090f3e to 2d64812 Compare November 3, 2026 21:50
@williamloo-scale
williamloo-scale force-pushed the wloo/website-gateway-auth branch from 4c1fcc1 to 22947c3 Compare November 3, 2026 22:52
@williamloo-scale
williamloo-scale force-pushed the wloo/website-sdk-followups branch 2 times, most recently from 0ef31b9 to 615d6a0 Compare November 3, 2026 23:47
@williamloo-scale
williamloo-scale force-pushed the wloo/website-gateway-auth branch from 22947c3 to 253eaec Compare November 3, 2026 23:47
williamloo-scale and others added 4 commits November 3, 2026 18:15
… conformance levels and models= (FD-4683)

This PR's change, rebased as one commit onto #443.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… so its own export loads back (FD-4683)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rents first, so its export loads back (FD-4683)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dels= sites; data/get alone (FD-4683)

- The store keeps no sessions: no `?sid=`, no `agentenv_sid_<name>` cookie, no `changed_sessions`; `self.store` is the
  site's one store, which the data plane loads, exports and resets.
- A models= site keeps no initial state and no diff; its data plane is its database's.
- Conformance runs the round trip with no skip for changed state or sessions.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@williamloo-scale
williamloo-scale force-pushed the wloo/website-sdk-followups branch from 718dbb1 to 65a1c8e Compare November 4, 2026 03:37
@williamloo-scale
williamloo-scale force-pushed the wloo/website-gateway-auth branch from 253eaec to 18b1b98 Compare November 4, 2026 03:37
Comment on lines +176 to +180
value = parsed.get(column.name)
if isinstance(value, str):
kind = _python_type(column)
if kind in _PARSERS:
parsed[column.name] = _PARSERS[kind](value.replace("Z", "+00:00") if kind is datetime.datetime else value)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Enum rows fail to restore

Tables.export() turns Python enum members into their values, but _row() does not turn them back into members. SQLAlchemy's Enum(State) stores member names by default. For a member such as OPEN = "open", the export contains "open" while PostgreSQL expects "OPEN".

Restoring that export fails. The conformance check calls data/reset first, so it can leave the site's tables empty. Convert exported enum values back to the column's enum members before inserting.

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/agentenv-protocol/src/agentenv_protocol/website/database.py
Line: 176-180

Comment:
**Enum rows fail to restore**

`Tables.export()` turns Python enum members into their values, but `_row()` does not turn them back into members. SQLAlchemy's `Enum(State)` stores member names by default. For a member such as `OPEN = "open"`, the export contains `"open"` while PostgreSQL expects `"OPEN"`.

Restoring that export fails. The conformance check calls `data/reset` first, so it can leave the site's tables empty. Convert exported enum values back to the column's enum members before inserting.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Cursor Fix in Claude Code Fix in Codex

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant