Skip to content

fix(computer): a screenshot while a dialog is open is its tab's last frame at once #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earakely-scale merged 1 commit into from
Nov 4, 2026
Merged

fix(computer): a screenshot while a dialog is open is its tab's last frame at once #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/agentenv-protocol/src/agentenv_protocol/website_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,10 @@ async def capture_page(self) -> dict:
return {**({"png": png} if png is not None else {"blank": True}), "page": self._state_of(target)}

async def _capture(self, session: str) -> Optional[str]:
"""The tab's page as it shows now; with a dialog open on it, which keeps it from painting, the last it took."""
target = self._sessions[session]
if session in self._open_dialogs:
return self._shots.get(target)
navigated = self.tabs.get(target, {}).get("url")
try:
shot = await self.devtools.call("Page.captureScreenshot", {"format": "png", "optimizeForSpeed": True},
Expand Down
3 changes: 2 additions & 1 deletion packages/agentenv-protocol/tests/test_website_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,14 +782,15 @@ async def call(self, method, params=None, *, session_id=None, timeout_s=None):


@pytest.mark.asyncio
async def test_while_a_dialog_keeps_its_page_from_painting_its_capture_is_the_last_it_took():
async def test_while_a_dialog_keeps_its_page_from_painting_its_capture_is_the_last_it_took_without_waiting_on_it():
devtools = Tabbed()
control = await _tabs(devtools, "a")
before = await control.capture()
devtools.blank.add("s-a")
devtools.send("Page.javascriptDialogOpening", {"type": "alert", "message": "Saved"}, session="s-a")

assert before == "png of s-a" and await control.capture() == "png of s-a"
assert len(devtools.timeouts) == 1


@pytest.mark.asyncio
Expand Down
Loading