Repository navigation
feat(computer): the probe's fixture records the same effects on macOS as on Linux - #483
Merged
earakely-scale merged 4 commits intoNov 4, 2026
Conversation
…1, macOS and Windows The Fixture Desk was written for X11's Tk, so a macOS driver failed four checks for the platform, not the driver. It now records Aqua's "," and " " keysyms under X11's names, binds Ctrl+/ to select-all itself (Tk does on X11 alone; Aqua's is Cmd+A), and counts <MouseWheel> events by their delta where Tk reports the wheel so (Aqua, Windows, Tk 9), X11's buttons 4 and 5 where Tk 8.6 does. layout.json's state says which windowing system it ran under. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Python may have none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ixels Tk 9 reports a scroll posted in pixels, as a macOS driver posts it, as <TouchpadScroll>, not <MouseWheel>, so the Fixture Desk's wheel saw none of cua-driver's scrolls on macOS. It now counts those by the lines they move, 10 pixels a line, since macOS coalesces quick scrolls into one event. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-5184-b4-a-conformance-fixture-that-knows-the-platform-so-a-macos
branch
November 4, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FD-5184. The conformance probe's Fixture Desk was written for X11's Tk. On macOS, cua-driver failed four full-probe checks because of how Aqua's Tk reports keys and the wheel, not because of the driver. The fixture now records the same effects under X11, Aqua and Windows. The probe's checks are unchanged.
What changes
In
computer/conformance/fixture.py:,and space by their character. The fixture records them under X11's names,commaandspace.<MouseWheel>. It is counted by its delta: 120 a notch where Tk scales it, else 1 a unit.<TouchpadScroll>. It is counted by the lines it moves, 10 px a line, because macOS coalesces quick scrolls into one event.layout.jsonrecords which one the fixture ran under.How it was tested
agentenv-cuaplugin at the head of feat(agentenv-cua): AgentEnv plugin for macOS VMs (lume provider, cua-driver macOS driver) trycua/cua#6405, on a bench image built with its recipe from Cua's base,ghcr.io/trycua/macos:26-20261021-fca2193(macOS 26.5.2, Tk 9 in the driver's Python). It ran on an EC2 mac2-m2.metal, with the full probe through a loopback relay.ruff checkpassed;🤖 Generated with Claude Code